LayoutTests/fast/dom/Window/resources/window-property-collector.js - Issue 216343002: Add a test that confirms there's no crash on accessing properties of AccesibilityObject at the init…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/Window/resources/window-property-collector.js

Issue 216343002: Add a test that confirms there's no crash on accessing properties of AccesibilityObject at the init… (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/accessibility/crash-on-accessing-properties-at-initial-state-expected.txt ('k') | Source/web/WebAXObject.cpp » ('j') | Source/web/WebAXObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/Window/resources/window-property-collector.js

diff --git a/LayoutTests/fast/dom/Window/resources/window-property-collector.js b/LayoutTests/fast/dom/Window/resources/window-property-collector.js

index 0578c8d46adccf4811b7105a05e527df2932789e..edc0c7a7c6b9bbd22e3991d320c84cc56a7a41bc 100644

--- a/LayoutTests/fast/dom/Window/resources/window-property-collector.js

+++ b/LayoutTests/fast/dom/Window/resources/window-property-collector.js

@@ -78,8 +78,6 @@ function collectPropertiesHelper(object, path)

// Skip the properties which are hard to expect a stable result.

// As for 'accessibilityController', we can hardly estimate the states

// of the cached WebAXObjects.

- // FIXME: We can't access accessibilityController's properties here

dmazzoni 2014/03/28 06:30:32 It looks like you're deleting the FIXME, but the s

hajimehoshi 2014/03/28 07:23:46 Done.

- // because some property accesses might crash (crbug/351195).

if (property == 'accessibilityController')

continue;

// As for 'localStorage', local storage is not reliably cleared between tests.