Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2163423002: mus: Each ServerWindowSurface should have a different client ID (Closed)

Created:
4 years, 5 months ago by Fady Samuel
Modified:
4 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Each ServerWindowSurface should have a different client ID We would like each SurfaceFactory to be tied to a single client ID and single SurfaceFactoryClient to simplify cc code and unify a bunch of code paths. Mus Window Server was an exception here. Two SurfaceFactories shared a single client ID. This has been changed. BUG=629940 Committed: https://crrev.com/182c30acd4d03bc820af9f2ecc49e3e2cd314b08 Cr-Commit-Position: refs/heads/master@{#406693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -54 lines) Patch
M services/ui/ws/server_window_surface.h View 3 chunks +1 line, -5 lines 0 comments Download
M services/ui/ws/server_window_surface.cc View 4 chunks +23 lines, -29 lines 0 comments Download
M services/ui/ws/server_window_surface_manager.h View 3 chunks +0 lines, -6 lines 0 comments Download
M services/ui/ws/server_window_surface_manager.cc View 3 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Fady Samuel
4 years, 5 months ago (2016-07-20 20:59:44 UTC) #3
Fady Samuel
4 years, 5 months ago (2016-07-20 20:59:45 UTC) #4
sky
LGTM
4 years, 5 months ago (2016-07-20 22:15:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163423002/1
4 years, 5 months ago (2016-07-20 22:20:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 22:26:11 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 22:28:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/182c30acd4d03bc820af9f2ecc49e3e2cd314b08
Cr-Commit-Position: refs/heads/master@{#406693}

Powered by Google App Engine
This is Rietveld 408576698