chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java - Issue 2163393003: Tab switcher theme colors no longer behind flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java

Issue 2163393003: Tab switcher theme colors no longer behind flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabListSceneLayer.java » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java

index 8a0e15736876aa2c0e7a5785d0e7cea47055e683..5a7fc237baec1a08bd8f6407f7669a0ef148f8c1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java

@@ -19,7 +19,6 @@ import org.chromium.chrome.browser.favicon.FaviconHelper.FaviconImageCallback;

import org.chromium.chrome.browser.profiles.Profile;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.browser.util.ColorUtils;

-import org.chromium.chrome.browser.util.FeatureUtilities;

import org.chromium.ui.base.DeviceFormFactor;

import org.chromium.ui.resources.ResourceManager;

import org.chromium.ui.resources.dynamics.BitmapDynamicResource;

@@ -108,9 +107,8 @@ public class LayerTitleCache implements TitleCache {

Bitmap originalFavicon = tab.getFavicon();

boolean isDarkTheme = tab.isIncognito();

- // If theme colors are enabled in the tab switcher, the theme might require lighter text.

- if (FeatureUtilities.areTabSwitcherThemeColorsEnabled()

- && !DeviceFormFactor.isTablet(mContext)) {

+ // The theme might require lighter text.

+ if (!DeviceFormFactor.isTablet(mContext)) {

isDarkTheme |= ColorUtils.shouldUseLightForegroundOnBackground(tab.getThemeColor());

}