tools/metrics/histograms/histograms.xml - Issue 2163393003: Tab switcher theme colors no longer behind flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2163393003: Tab switcher theme colors no longer behind flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index ffbcd4f2406d7be5eb71d70e82f0147f8fd53e53..483bf203e7669a6450eb32b6249f6b282e9e9a5d 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -82355,7 +82355,6 @@ To add a new entry, add it with any value and run test to compute valid value.

- <int value="423855924" label="enable-tab-switcher-theme-colors"/>

gone 2016/07/28 16:20:18 Feels like littering, but you never remove a flag

mdjones 2016/07/28 16:50:42 I know that's the rule for histograms, I didn't th

rkaplow 2016/07/28 19:47:23 Dan's right, it is preferable to keep the enum, as

mdjones 2016/07/28 20:31:33 Done.

<int value="455698038"

« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | no next file » | no next file with comments »