DevTools: Give autocomplete suggestions even after brackets

third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @implements {WebInspector.TargetManager.Observer}
  * @param {!WebInspector.TargetManager} targetManager
  * @param {!WebInspector.Context} context
  */
@@ skipping 186 matching lines @@
  */
 WebInspector.ExecutionContextSelector.completionsForTextPromptInCurrentContext = function(proxyElement, text, cursorOffset, wordRange, force, completionsReadyCallback)
 {
     var executionContext = WebInspector.context.flavor(WebInspector.ExecutionContext);
     if (!executionContext) {
         completionsReadyCallback([]);
         return;
     }
 
     // Pass less stop characters to rangeOfWord so the range will be a more complete expression.
-    var expressionRange = wordRange.startContainer.rangeOfWord(wordRange.startOffset, " =:({;,!+-*/&|^<>", proxyElement, "backward");
+    var expressionRange = wordRange.startContainer.rangeOfWord(wordRange.startOffset, " =:({;,!+-*/&|^<>`", proxyElement, "backward");
     var expressionString = expressionRange.toString();
 
-    // The "[" is also a stop character, except when it's the last character of the expression.
-    var pos = expressionString.lastIndexOf("[", expressionString.length - 2);
-    if (pos !== -1)
-        expressionString = expressionString.substr(pos + 1);
+    var bracketCount = 0;
+    var index = expressionString.length - 1;
+    while (index >= 0) {
+        var character = expressionString.charAt(index);
+        if (character === "]")
+            bracketCount++;
+        // Allow an open bracket at the end for property completion.
+        if (character === "[" && index < expressionString.length - 1) {
+            bracketCount--;
+            if (bracketCount < 0)
+                break;
+        }
+        index--;
+    }
+    expressionString = expressionString.substr(index + 1);

[lushnikov, 2016/07/25 18:12:29]

nit: we tend to use substring in all cases where possible

[einbinder, 2016/07/25 20:11:35]

Done.

 
     var prefix = wordRange.toString();
     executionContext.completionsForExpression(expressionString, text, cursorOffset, prefix, force, completionsReadyCallback);
 }