Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Issue 2163373008: [Mac/GN] Update sizes.py to use unstripped build output for reporting static initializers. (Closed)

Created:
4 years, 5 months ago by Robert Sesek
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Update sizes.py to use unstripped build output for reporting static initializers. This uses the new tool in //tools/mac/show_mod_init_func.py to display the function names. BUG=628052 R=mark@chromium.org,dpranke@chromium.org Committed: https://crrev.com/7ca703764dc9a08fa26537ca96ca5cc0edb01df4 Cr-Commit-Position: refs/heads/master@{#406999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -7 lines) Patch
M infra/scripts/legacy/scripts/slave/chromium/sizes.py View 3 chunks +29 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Robert Sesek
mark: Since you reviewed the show_mod_inic_func.py script dpranke: OWNERS
4 years, 5 months ago (2016-07-21 22:23:42 UTC) #3
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-21 22:26:30 UTC) #4
Mark Mentovai
LGTM. The variable named show_mod_init_func confused me momentarily. I expected it to be a reference ...
4 years, 5 months ago (2016-07-21 23:29:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163373008/1
4 years, 5 months ago (2016-07-22 00:00:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 00:04:18 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 00:06:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ca703764dc9a08fa26537ca96ca5cc0edb01df4
Cr-Commit-Position: refs/heads/master@{#406999}

Powered by Google App Engine
This is Rietveld 408576698