|
|
Created:
4 years, 5 months ago by jochen (gone - plz use gerrit) Modified:
4 years, 5 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd OWNERS for expat
R=nick@chromium.org,dominicc@chromium.org
BUG=
Committed: https://crrev.com/4dced320561af10d1a2c5264598b855886c236d3
Cr-Commit-Position: refs/heads/master@{#407006}
Patch Set 1 #
Messages
Total messages: 16 (5 generated)
Nick, because you added the library initially, Dominic, because you own the libxml stuff anyways
nick@chromium.org changed reviewers: + zea@chromium.org
I'm not really a stakeholder of this directory anymore; though I would be happy to try to review rolls if nobody else steps up. Originally we needed expat for sync because of libjingle. I'm not sure that a sync->libjingle dependency still exists? It looks like the current stakeholders are webrtc and possibly some android font stuff? +zea and +tommi -- do you know who cares about expat?
Sync uses libjingle for a few integration tests still, but we're in the process of trying to get rid of those final dependencies. Someone from webrtc, as you say, might be best? On Thu, Jul 21, 2016 at 10:12 AM <nick@chromium.org> wrote: > I'm not really a stakeholder of this directory anymore; though I would be > happy > to try to review rolls if nobody else steps up. > > Originally we needed expat for sync because of libjingle. I'm not sure > that a > sync->libjingle dependency still exists? It looks like the current > stakeholders > are webrtc and possibly some android font stuff? > > +zea and +tommi -- do you know who cares about expat? > > https://codereview.chromium.org/2163373006/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
lgtm
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by dominicc@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add OWNERS for expat R=nick@chromium.org,dominicc@chromium.org BUG= ========== to ========== Add OWNERS for expat R=nick@chromium.org,dominicc@chromium.org BUG= Committed: https://crrev.com/4dced320561af10d1a2c5264598b855886c236d3 Cr-Commit-Position: refs/heads/master@{#407006} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4dced320561af10d1a2c5264598b855886c236d3 Cr-Commit-Position: refs/heads/master@{#407006} |