Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2163373005: Add trace event for DrawingBuffer::prepareMailbox in blink category. (Closed)

Created:
4 years, 5 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 5 months ago
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, rwlbuis, Stephen Chennney, ulan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add trace event for DrawingBuffer::prepareMailbox in blink category. (Attempted to put this in the "gpu" category but ran into http://crbug.com/630030 .) This will help in the creation of TBMv2 WebGL benchmarks. BUG=catapult:#2446 Committed: https://crrev.com/d3c83a8af9a2c06a49b16e26f43ea7338a72e283 Cr-Commit-Position: refs/heads/master@{#406737}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Ken Russell (switch to Gerrit)
(alexandermont or charliea) and zmo: please review. Thanks. What bug ID should this reference? ulan: ...
4 years, 5 months ago (2016-07-20 23:26:19 UTC) #2
alexandermont
lgtm
4 years, 5 months ago (2016-07-20 23:27:31 UTC) #3
Ken Russell (switch to Gerrit)
Since the bug ID link to the Catapult repo doesn't work: https://github.com/catapult-project/catapult/issues/2446 .
4 years, 5 months ago (2016-07-20 23:37:32 UTC) #5
Zhenyao Mo
lgtm
4 years, 5 months ago (2016-07-20 23:58:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163373005/1
4 years, 5 months ago (2016-07-21 00:00:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 01:21:28 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 01:25:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3c83a8af9a2c06a49b16e26f43ea7338a72e283
Cr-Commit-Position: refs/heads/master@{#406737}

Powered by Google App Engine
This is Rietveld 408576698