Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2163353002: Labeling bisect/perf try jobs with a prominent null step. (Closed)

Created:
4 years, 5 months ago by RobertoCN
Modified:
4 years, 4 months ago
Reviewers:
eakuefner, sullivan, dtu
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Labeling bisect/perf try jobs with a prominent null step. While triaging bisect failures I noticed that it's not always easy to distringuish between a tryjob and a bisect. For this I added a null step that displays a prominent string to identify the type of job. R=sullivan@chromium.org,dtu@chromium.org,eakuefner@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/build/+/85dc563ddd3caa560307c9d79a6d4842f83dace8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+467 lines, -4 lines) Patch
M scripts/slave/recipe_modules/auto_bisect/api.py View 5 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_fyi_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus5X_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus5_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus6_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus7_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus9_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_one_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_s5_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_s5_perf_cq.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_webview_arm64_aosp_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_fyi_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5X_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus6_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus7_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus9_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_one_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_cq.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_webview_arm64_aosp_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_fyi_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5X_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus6_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus7_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus9_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_one_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_cq.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_webview_arm64_aosp_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_fyi_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5X_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus6_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus7_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus9_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_cq.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_webview_arm64_aosp_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_fyi_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus5X_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus5_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus6_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus7_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus9_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_one_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_s5_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_s5_perf_cq.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_webview_arm64_aosp_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_basic_device.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_disconnected_device.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_failed_device.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_no_device.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_fyi_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus5X_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus5_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus6_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus7_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus9_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_one_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_s5_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_s5_perf_cq.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_webview_arm64_aosp_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_fyi_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus5X_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus5_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus6_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus7_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus9_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_one_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_s5_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_s5_perf_cq.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_webview_arm64_aosp_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_fyi_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus5X_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus5_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus6_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus7_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus9_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_one_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_s5_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_s5_perf_cq.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_webview_arm64_aosp_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_fyi_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus5X_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus5_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus6_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus7_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus9_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_one_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_s5_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_s5_perf_cq.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_webview_arm64_aosp_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_fyi_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5X_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus6_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus7_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus9_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_one_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_cq.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_webview_arm64_aosp_perf_bisect.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_linux_bisect_tester_recipe.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_linux_bisect_tester_recipe_ret_code.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_metric.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_revisions.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_no_benchmark_to_run.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_no_changes.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_run_benchmark.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/perf_tryjob_config_error.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/perf_tryjob_failed_test.json View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
RobertoCN
4 years, 5 months ago (2016-07-20 19:12:15 UTC) #1
eakuefner
lgtm
4 years, 5 months ago (2016-07-20 19:16:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163353002/1
4 years, 5 months ago (2016-07-20 19:17:43 UTC) #4
dtu
great, lgtm
4 years, 5 months ago (2016-07-20 20:02:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit (Swarming) on master.tryserver.infra (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3022ac0c967c3e10)
4 years, 5 months ago (2016-07-20 20:19:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163353002/1
4 years, 4 months ago (2016-07-26 18:32:38 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 18:36:53 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/85dc563ddd3caa560307...

Powered by Google App Engine
This is Rietveld 408576698