Issue 216333003: drive: Do not try to UpdateResource with empty resource ID

Issue 216333003: drive: Do not try to UpdateResource with empty resource ID (Closed)

Created:
6 years, 9 months ago by hashimoto

Modified:
6 years, 9 months ago

Reviewers:
kinaba

CC:
chromium-reviews, tim+watch_chromium.org, nkostylev+watch_chromium.org, tfarina, haitaol+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, maniscalco+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Do not try to UpdateResource with empty resource ID should_content_update may be false for new files if it's opend. BUG=353680 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260183

Patch Set 1 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -3 lines)			Patch
	M	chrome/browser/chromeos/drive/sync/entry_update_performer.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
	M	chrome/browser/chromeos/drive/sync/entry_update_performer_unittest.cc	View		1 chunk	+74 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/216333003/40001

6 years, 9 months ago (2014-03-28 09:29:48 UTC) #4

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 9 months ago (2014-03-28 12:21:09 UTC) #5

commit-bot: I haz the power

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=137177

6 years, 9 months ago (2014-03-28 12:21:10 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/216333003/40001

6 years, 9 months ago (2014-03-28 15:06:00 UTC) #8

Message was sent while issue was closed.

Change committed as 260183

Expand Messages | Collapse Messages