Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 2163323002: Add desired width & height to drawContext (as opposed to using the width & height of the RT) (Closed)

Created:
4 years, 5 months ago by robertphillips
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add desired width & height to drawContext (as opposed to using the width & height of the RT) This is split out of: https://codereview.chromium.org/2168483003/ (Deprecate SkDevice::accessBitmap method). The GPUDevice can no longer rely on the fLegacyBitmap to store the device's width & height GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163323002

Patch Set 1 #

Patch Set 2 : Clean up #

Patch Set 3 : More Clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -56 lines) Patch
M include/gpu/GrContext.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M include/gpu/GrDrawContext.h View 1 3 chunks +8 lines, -3 lines 0 comments Download
M src/core/SkSpecialSurface.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 1 2 5 chunks +11 lines, -7 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 3 chunks +6 lines, -3 lines 0 comments Download
M src/gpu/GrDrawingManager.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrDrawingManager.cpp View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
M src/gpu/GrPathRenderingDrawContext.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrRenderTarget.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.h View 1 2 3 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 6 chunks +11 lines, -16 lines 0 comments Download
M src/image/SkSurface_Gpu.cpp View 1 2 5 chunks +9 lines, -5 lines 0 comments Download
M tests/RectangleTextureTest.cpp View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
robertphillips
4 years, 5 months ago (2016-07-20 20:00:33 UTC) #4
bsalomon
Hm, why does the draw context need to know which portion to client is rendering ...
4 years, 5 months ago (2016-07-21 13:43:43 UTC) #9
robertphillips
On 2016/07/21 13:43:43, bsalomon wrote: > Hm, why does the draw context need to know ...
4 years, 5 months ago (2016-07-21 13:49:07 UTC) #10
robertphillips
4 years, 5 months ago (2016-07-21 14:49:16 UTC) #11
Message was sent while issue was closed.
Moth-balling for now. Will revisit when drawContext's are RenderTargetProxy
backed. Hopefully it will make more sense then.

Powered by Google App Engine
This is Rietveld 408576698