Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2163283002: re-disable save/restore peephole optimization (Closed)

Created:
4 years, 5 months ago by reed1
Modified:
4 years, 5 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : disable unitest until bigger fix #

Patch Set 3 : I hate un-called-function-warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/core/SkRecordOpts.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M tests/PictureTest.cpp View 1 2 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
reed1
ptal
4 years, 5 months ago (2016-07-20 17:03:18 UTC) #3
mtklein
lgtm
4 years, 5 months ago (2016-07-20 17:05:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163283002/1
4 years, 5 months ago (2016-07-20 17:08:24 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/9835)
4 years, 5 months ago (2016-07-20 17:13:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163283002/20001
4 years, 5 months ago (2016-07-20 17:48:53 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/9859)
4 years, 5 months ago (2016-07-20 17:53:23 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163283002/40001
4 years, 5 months ago (2016-07-20 18:04:15 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 18:25:00 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/de996a0df79038c0559f8681233e1a82220d2f3d

Powered by Google App Engine
This is Rietveld 408576698