Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1263)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2163273002: [Fetch] Accept URLSearchParams in Response constructor (Closed)

Created:
4 years, 5 months ago by e_hakkinen
Modified:
4 years, 5 months ago
CC:
chromium-reviews, blink-reviews, haraken, hiroshige, dmurph
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Fetch] Accept URLSearchParams in Response constructor BUG=412027 Committed: https://crrev.com/de4c459772411000491c490239b596302fafc470 Cr-Commit-Position: refs/heads/master@{#406829}

Patch Set 1 #

Total comments: 6

Patch Set 2 : var => const, an => a, -TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response-content.js View 1 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.cpp View 1 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
e_hakkinen
PTAL.
4 years, 5 months ago (2016-07-20 16:45:34 UTC) #2
tyoshino (SeeGerritForStatus)
+yhirano https://codereview.chromium.org/2163273002/diff/1/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response-content.js File third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response-content.js (right): https://codereview.chromium.org/2163273002/diff/1/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response-content.js#newcode125 third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response-content.js:125: 'A Response constructed with an URLSearchParams should have ...
4 years, 5 months ago (2016-07-21 07:30:28 UTC) #4
yhirano
lgtm, thanks! https://codereview.chromium.org/2163273002/diff/1/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response-content.js File third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response-content.js (right): https://codereview.chromium.org/2163273002/diff/1/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response-content.js#newcode118 third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response-content.js:118: var urlSearchParams = new URLSearchParams(); I prefer ...
4 years, 5 months ago (2016-07-21 09:00:27 UTC) #5
e_hakkinen
https://codereview.chromium.org/2163273002/diff/1/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response-content.js File third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response-content.js (right): https://codereview.chromium.org/2163273002/diff/1/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response-content.js#newcode118 third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response-content.js:118: var urlSearchParams = new URLSearchParams(); On 2016/07/21 09:00:27, yhirano ...
4 years, 5 months ago (2016-07-21 12:02:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163273002/20001
4 years, 5 months ago (2016-07-21 12:02:55 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 13:07:24 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 13:08:46 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/de4c459772411000491c490239b596302fafc470
Cr-Commit-Position: refs/heads/master@{#406829}

Powered by Google App Engine
This is Rietveld 408576698