Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 2163263002: Reland of [builtins] Introduce a builtin for Abort(). (Closed)

Created:
4 years, 5 months ago by ahaas
Modified:
4 years, 5 months ago
CC:
Hannes Payer (out of office), ulan, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [builtins] Introduce a builtin for Abort(). Original message: Calling Runtime::kAbort through a builtin instead of the c-entry stub will allow to generate the call in a background thread, because a builtin provides its own handle, whereas a code stub does not. @v8-mips-ports: Could you take a special look at the padding that is done in MacroAssembler::Abort()? Reason for revert: The reason for reverting is: Blocks roll: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/builds/1622 The problem was that on arm64 the builtin for Abort() contained a call to Abort(). The problem is fixed by using a NoUseRealAbortsScope in the code generation of Abort(). R=titzer@chromium.org, rmcilroy@chromium.org, rodolph.perfetta@arm.com Committed: https://crrev.com/66cb026f4a54987bb4dc9e1d4734086571b872e0 Cr-Commit-Position: refs/heads/master@{#37929}

Patch Set 1 #

Patch Set 2 : Fix the problem on arm64. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -26 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M src/builtins/arm/builtins-arm.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M src/isolate.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
ahaas
4 years, 5 months ago (2016-07-20 16:27:50 UTC) #3
Rodolph Perfetta (ARM)
arm, arm64 part lgtm.
4 years, 5 months ago (2016-07-20 18:28:00 UTC) #6
Hannes Payer (out of office)
heap lgtm
4 years, 5 months ago (2016-07-21 08:49:17 UTC) #8
titzer
lgtm
4 years, 5 months ago (2016-07-21 08:52:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163263002/20001
4 years, 5 months ago (2016-07-21 08:54:54 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 09:10:47 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 09:13:52 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66cb026f4a54987bb4dc9e1d4734086571b872e0
Cr-Commit-Position: refs/heads/master@{#37929}

Powered by Google App Engine
This is Rietveld 408576698