[stubs] Port store IC dispatcher to TurboFan.

[stubs] Port store IC dispatcher to TurboFan.

This CL introduces StoreICTFStub and StoreICTrampolineTFStub and a switch
to enable them instead of respective platform stubs.

This should ease the split of StoreIC to StoreGlobalIC and StoreIC.

StubCache tests now exercise both load and store ICs.

BUG=chromium:576312
Committed: https://crrev.com/2390243564547a8ca934785e6ab9f0cfb8956834
Cr-Commit-Position: refs/heads/master@{#39751}

[Igor Sheludko, 2016-07-20 15:39:59]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 15:40:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-07-20 15:40:14]

Description was changed from

==========
[stubs] Introducing StoreICTFStub and StoreICTrampolineTFStub and a switch to
enable them instead of respective platform stubs.

StubCache tests now exersices both load IC and store IC.
==========

to

==========
[stubs] Introducing StoreICTFStub and StoreICTrampolineTFStub and a switch to
enable them instead of respective platform stubs.

StubCache tests now exersice both load IC and store IC.
==========

[Igor Sheludko, 2016-07-20 15:40:47]

Description was changed from

==========
[stubs] Introducing StoreICTFStub and StoreICTrampolineTFStub and a switch to
enable them instead of respective platform stubs.

StubCache tests now exersice both load IC and store IC.
==========

to

==========
[stubs] Introducing StoreICTFStub and StoreICTrampolineTFStub and a switch to
enable them instead of respective platform stubs.

StubCache tests now exercise both load IC and store IC.
==========

[Igor Sheludko, 2016-07-20 15:40:56]

Description was changed from

==========
[stubs] Introducing StoreICTFStub and StoreICTrampolineTFStub and a switch to
enable them instead of respective platform stubs.

StubCache tests now exercise both load IC and store IC.
==========

to

==========
[stubs] Introducing StoreICTFStub and StoreICTrampolineTFStub and a switch to
enable them instead of respective platform stubs.

StubCache tests now exercise both load and store ICs.
==========

[commit-bot: I haz the power, 2016-07-20 16:06:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 16:06:46]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/9387)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[Igor Sheludko, 2016-09-23 16:14:54]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-09-23 16:17:06]

Patchset #1 (id:20001) has been deleted

[Igor Sheludko, 2016-09-24 14:59:11]

Description was changed from

==========
[stubs] Introducing StoreICTFStub and StoreICTrampolineTFStub and a switch to
enable them instead of respective platform stubs.

StubCache tests now exercise both load and store ICs.
==========

to

==========
[stubs] Port store IC dispatcher to TurboFan.

This CL introduces StoreICTFStub and StoreICTrampolineTFStub and a switch
to enable them instead of respective platform stubs.

StubCache tests now exercise both load and store ICs.

BUG=v8:
==========

[Igor Sheludko, 2016-09-26 09:28:51]

Patchset #1 (id:40001) has been deleted

[Igor Sheludko, 2016-09-26 09:31:23]

Description was changed from

==========
[stubs] Port store IC dispatcher to TurboFan.

This CL introduces StoreICTFStub and StoreICTrampolineTFStub and a switch
to enable them instead of respective platform stubs.

StubCache tests now exercise both load and store ICs.

BUG=v8:
==========

to

==========
[stubs] Port store IC dispatcher to TurboFan.

This CL introduces StoreICTFStub and StoreICTrampolineTFStub and a switch
to enable them instead of respective platform stubs.

This should ease the split of StoreIC to StoreGlobalIC and StoreIC.

StubCache tests now exercise both load and store ICs.

BUG=chromium:576312
==========

[Igor Sheludko, 2016-09-26 09:32:11]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 09:32:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-09-26 09:47:32]

ishell@chromium.org changed reviewers:
+ bmeurer@chromium.org, jkummerow@chromium.org

[Igor Sheludko, 2016-09-26 09:47:33]

Benedikt, PTAL compiler
Jakob, PTAL the rest

[commit-bot: I haz the power, 2016-09-26 09:58:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 09:58:55]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2016-09-26 10:28:28]

LGTM on compiler.

[Jakob Kummerow, 2016-09-26 23:32:31]

LGTM with nits.

https://codereview.chromium.org/2163253002/diff/60001/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/2163253002/diff/60001/src/code-stubs.cc#newco...
src/code-stubs.cc:505: Node* receiver = assembler->Parameter(0);
Don't we have named constants now? I.e. s/0/Descriptor::kReceiver/ (and so on
for the following lines).

https://codereview.chromium.org/2163253002/diff/60001/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/2163253002/diff/60001/src/code-stubs.h#newcod...
src/code-stubs.h:2428: explicit StoreICTrampolineTFStub(Isolate* isolate, const
StoreICState& state)
nit: "explicit" is unnecessary here

https://codereview.chromium.org/2163253002/diff/60001/src/code-stubs.h#newcod...
src/code-stubs.h:2577: explicit StoreICTFStub(Isolate* isolate, const
StoreICState& state)
nit: "explicit" is unnecessary here

https://codereview.chromium.org/2163253002/diff/60001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/2163253002/diff/60001/test/cctest/test-api.cc...
test/cctest/test-api.cc:21879: +#if !V8_TARGET_ARCH_IA32 && !V8_TARGET_ARCH_X87
Why is this still platform specific?

[Igor Sheludko, 2016-09-27 06:46:06]

Thanks!

https://codereview.chromium.org/2163253002/diff/60001/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/2163253002/diff/60001/src/code-stubs.cc#newco...
src/code-stubs.cc:505: Node* receiver = assembler->Parameter(0);
On 2016/09/26 23:32:30, Jakob Kummerow wrote:
> Don't we have named constants now? I.e. s/0/Descriptor::kReceiver/ (and so on
> for the following lines).

This CL was crafted before code stub refactoring. Thanks. Done.

https://codereview.chromium.org/2163253002/diff/60001/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/2163253002/diff/60001/src/code-stubs.h#newcod...
src/code-stubs.h:2428: explicit StoreICTrampolineTFStub(Isolate* isolate, const
StoreICState& state)
On 2016/09/26 23:32:30, Jakob Kummerow wrote:
> nit: "explicit" is unnecessary here

Done.

https://codereview.chromium.org/2163253002/diff/60001/src/code-stubs.h#newcod...
src/code-stubs.h:2577: explicit StoreICTFStub(Isolate* isolate, const
StoreICState& state)
On 2016/09/26 23:32:30, Jakob Kummerow wrote:
> nit: "explicit" is unnecessary here

Done.

https://codereview.chromium.org/2163253002/diff/60001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/2163253002/diff/60001/test/cctest/test-api.cc...
test/cctest/test-api.cc:21879: +#if !V8_TARGET_ARCH_IA32 && !V8_TARGET_ARCH_X87
On 2016/09/26 23:32:30, Jakob Kummerow wrote:
> Why is this still platform specific?

Forgot to cleanup. Done.

[Igor Sheludko, 2016-09-27 06:47:15]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 06:47:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 07:16:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 07:16:23]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-09-27 07:17:53]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-09-27 07:17:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2163253002/#ps80001
(title: "Addressing comments")

[commit-bot: I haz the power, 2016-09-27 07:18:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 07:20:42]

Description was changed from

==========
[stubs] Port store IC dispatcher to TurboFan.

This CL introduces StoreICTFStub and StoreICTrampolineTFStub and a switch
to enable them instead of respective platform stubs.

This should ease the split of StoreIC to StoreGlobalIC and StoreIC.

StubCache tests now exercise both load and store ICs.

BUG=chromium:576312
==========

to

==========
[stubs] Port store IC dispatcher to TurboFan.

This CL introduces StoreICTFStub and StoreICTrampolineTFStub and a switch
to enable them instead of respective platform stubs.

This should ease the split of StoreIC to StoreGlobalIC and StoreIC.

StubCache tests now exercise both load and store ICs.

BUG=chromium:576312
==========

[commit-bot: I haz the power, 2016-09-27 07:20:44]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-09-27 07:20:59]

Description was changed from

==========
[stubs] Port store IC dispatcher to TurboFan.

This CL introduces StoreICTFStub and StoreICTrampolineTFStub and a switch
to enable them instead of respective platform stubs.

This should ease the split of StoreIC to StoreGlobalIC and StoreIC.

StubCache tests now exercise both load and store ICs.

BUG=chromium:576312
==========

to

==========
[stubs] Port store IC dispatcher to TurboFan.

This CL introduces StoreICTFStub and StoreICTrampolineTFStub and a switch
to enable them instead of respective platform stubs.

This should ease the split of StoreIC to StoreGlobalIC and StoreIC.

StubCache tests now exercise both load and store ICs.

BUG=chromium:576312

Committed: https://crrev.com/2390243564547a8ca934785e6ab9f0cfb8956834
Cr-Commit-Position: refs/heads/master@{#39751}
==========

[commit-bot: I haz the power, 2016-09-27 07:21:00]

Patchset 2 (id:??) landed as
https://crrev.com/2390243564547a8ca934785e6ab9f0cfb8956834
Cr-Commit-Position: refs/heads/master@{#39751}