Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 2163223005: Remove //content dependency for tests in certificate_reporting (Closed)

Created:
4 years, 5 months ago by estark
Modified:
4 years, 5 months ago
Reviewers:
felt
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove //content dependency for tests in certificate_reporting This is a follow-up to https://codereview.chromium.org/2120683002, suggested in https://codereview.chromium.org/2120683002/#msg38. BUG= Committed: https://crrev.com/6dad122faae155a72c7064b7b02a8850e454e393 Cr-Commit-Position: refs/heads/master@{#406880}

Patch Set 1 #

Patch Set 2 : remove #include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M components/certificate_reporting/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/certificate_reporting/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/certificate_reporting/error_reporter_unittest.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
estark
felt: PTAL? (see https://codereview.chromium.org/2120683002/#msg38 for justification)
4 years, 5 months ago (2016-07-21 03:42:28 UTC) #10
felt
nice fix, lgtm
4 years, 5 months ago (2016-07-21 16:53:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163223005/20001
4 years, 5 months ago (2016-07-21 16:53:58 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 16:58:54 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 17:00:11 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6dad122faae155a72c7064b7b02a8850e454e393
Cr-Commit-Position: refs/heads/master@{#406880}

Powered by Google App Engine
This is Rietveld 408576698