Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 2163213004: Use dFdx in Vulkan to address distance field issues. (Closed)

Created:
4 years, 5 months ago by jvanverth1
Modified:
4 years, 5 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use dFdx in Vulkan to address distance field issues. On Nexus Player and occasionally Nexus 5x we get transparent boxes around paths. This appears to be because the dFdy call is not as accurate as dFdx, which is the opposite of Mali 400. As Mali 400 is not supported with Vulkan, we can go back to using dFdx in this case. BUG=skia:5523 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163213004 Committed: https://skia.googlesource.com/skia/+/e499adf328bd7fc15a755325749f54c2b7e71f54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -5 lines) Patch
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 4 chunks +32 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
jvanverth1
4 years, 5 months ago (2016-07-20 18:27:28 UTC) #3
egdaniel
lgtm
4 years, 5 months ago (2016-07-20 18:36:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163213004/1
4 years, 5 months ago (2016-07-20 18:47:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/e499adf328bd7fc15a755325749f54c2b7e71f54
4 years, 5 months ago (2016-07-20 19:22:17 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 19:22:19 UTC) #9
Message was sent while issue was closed.
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698