Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Issue 2163193002: Reject payment request with AbortError if web page rejects promise from updateWith. (Closed)

Created:
4 years, 5 months ago by pals
Modified:
4 years, 5 months ago
CC:
chromium-reviews, blink-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reject payment request with AbortError if web page rejects promise from updateWith. Specification: https://www.w3.org/TR/payment-request/#updatewith BUG=629461 Committed: https://crrev.com/6647b5b4a0730a86bd088241216d1905ba7507ce Cr-Commit-Position: refs/heads/master@{#406754}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
pals
PTAL.
4 years, 5 months ago (2016-07-20 10:15:21 UTC) #3
please use gerrit instead
lgtm
4 years, 5 months ago (2016-07-20 14:19:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163193002/1
4 years, 5 months ago (2016-07-21 01:52:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 03:17:53 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 03:20:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6647b5b4a0730a86bd088241216d1905ba7507ce
Cr-Commit-Position: refs/heads/master@{#406754}

Powered by Google App Engine
This is Rietveld 408576698