Fix PerformanceResourceTiming transferSize field for sync XHR

Fix PerformanceResourceTiming transferSize field for sync XHR

Previously the transferSize field for synchronous XHR was only being set
when devtools was open. Set it always.

This CL also adds a layout test specifically for this case.

BUG=629764
TBR=esprehn,hubbe

Committed: https://crrev.com/c572809b49cae15c0697aa056990c9bf660a068f
Cr-Commit-Position: refs/heads/master@{#408085}

[Adam Rice, 2016-07-20 07:59:48]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 08:00:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 08:11:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 08:11:49]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Adam Rice, 2016-07-20 08:50:23]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 08:50:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 11:36:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 11:36:33]

Dry run: This issue passed the CQ dry run.

[Adam Rice, 2016-07-21 03:33:46]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 03:34:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Adam Rice, 2016-07-21 03:34:48]

ricea@chromium.org changed reviewers:
+ ksakamoto@chromium.org

[Kunihiko Sakamoto, 2016-07-21 04:05:43]

lgtm

https://codereview.chromium.org/2163183002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/misc/resources/resource-timing-sizes-sync-xhr-transfer-size.js
(right):

https://codereview.chromium.org/2163183002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/misc/resources/resource-timing-sizes-sync-xhr-transfer-size.js:1:
// This test code is shared between resource-timing-sizes-redirect.html and
Please update this comment.

[commit-bot: I haz the power, 2016-07-21 04:08:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 04:08:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Adam Rice, 2016-07-21 04:13:52]

https://codereview.chromium.org/2163183002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/misc/resources/resource-timing-sizes-sync-xhr-transfer-size.js
(right):

https://codereview.chromium.org/2163183002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/misc/resources/resource-timing-sizes-sync-xhr-transfer-size.js:1:
// This test code is shared between resource-timing-sizes-redirect.html and
On 2016/07/21 04:05:43, Kunihiko Sakamoto wrote:
> Please update this comment.

Sorry. Done.

[Adam Rice, 2016-07-21 04:14:00]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 04:14:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 04:17:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 04:17:45]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Adam Rice, 2016-07-21 04:54:21]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 04:54:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 05:35:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 05:35:41]

Dry run: This issue passed the CQ dry run.

[Adam Rice, 2016-07-21 05:37:19]

ricea@chromium.org changed reviewers:
+ kinuko@chromium.org

[kinuko, 2016-07-21 07:52:45]

lgtm

[Adam Rice, 2016-07-27 08:34:37]

Description was changed from

==========
Fix PerformanceResourceTiming transferSize field for sync XHR

Previously the transferSize field for synchronous XHR was only being set
when devtools was open. Set it always.

This CL also adds a layout test specifically for this case.

BUG=629764
==========

to

==========
Fix PerformanceResourceTiming transferSize field for sync XHR

Previously the transferSize field for synchronous XHR was only being set
when devtools was open. Set it always.

This CL also adds a layout test specifically for this case.

BUG=629764
TBR=esprehn,hubbe
==========

[Adam Rice, 2016-07-27 08:36:15]

ricea@chromium.org changed reviewers:
+ esprehn@chromium.org, hubbe@chromium.org

[Adam Rice, 2016-07-27 08:36:16]

TBR esprehn for trivial changes in third_party/WebKit/Source/web/

TBR hubbe for trivial change to media/blink/mock_weburlloader.h

[Adam Rice, 2016-07-27 08:36:25]

The CQ bit was checked by ricea@chromium.org

[Adam Rice, 2016-07-27 08:36:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
ksakamoto@chromium.org, kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/2163183002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-07-27 08:36:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-07-27 08:49:55]

I'd sort of rather we didn't fix this, sync xhr is deprecated and we said we
wouldn't add any more features to it. Who actually reported needing this? The
bug has no details.

[Adam Rice, 2016-07-27 09:25:55]

On 2016/07/27 08:49:55, esprehn wrote:
> I'd sort of rather we didn't fix this, sync xhr is deprecated and we said we
> wouldn't add any more features to it. Who actually reported needing this? The
> bug has no details.

I've just been thinking of it purely as a correctness issue. The other
PerformanceResourceTiming fields are populated for Sync XHR, so it's hard
to justify it as a policy decision.

The three size fields (transferSize, decodedBodySize, encodedBodySize) have
been available in Canary for less than a week, so there hasn't been time for
anyone to notice and complain.

[commit-bot: I haz the power, 2016-07-27 10:08:46]

Description was changed from

==========
Fix PerformanceResourceTiming transferSize field for sync XHR

Previously the transferSize field for synchronous XHR was only being set
when devtools was open. Set it always.

This CL also adds a layout test specifically for this case.

BUG=629764
TBR=esprehn,hubbe
==========

to

==========
Fix PerformanceResourceTiming transferSize field for sync XHR

Previously the transferSize field for synchronous XHR was only being set
when devtools was open. Set it always.

This CL also adds a layout test specifically for this case.

BUG=629764
TBR=esprehn,hubbe
==========

[commit-bot: I haz the power, 2016-07-27 10:08:47]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-27 10:10:29]

Description was changed from

==========
Fix PerformanceResourceTiming transferSize field for sync XHR

Previously the transferSize field for synchronous XHR was only being set
when devtools was open. Set it always.

This CL also adds a layout test specifically for this case.

BUG=629764
TBR=esprehn,hubbe
==========

to

==========
Fix PerformanceResourceTiming transferSize field for sync XHR

Previously the transferSize field for synchronous XHR was only being set
when devtools was open. Set it always.

This CL also adds a layout test specifically for this case.

BUG=629764
TBR=esprehn,hubbe

Committed: https://crrev.com/c572809b49cae15c0697aa056990c9bf660a068f
Cr-Commit-Position: refs/heads/master@{#408085}
==========

[commit-bot: I haz the power, 2016-07-27 10:10:31]

Patchset 5 (id:??) landed as
https://crrev.com/c572809b49cae15c0697aa056990c9bf660a068f
Cr-Commit-Position: refs/heads/master@{#408085}