Issue 2163173003: VM: Remove _GrowableList.from which was never called.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2163173003: VM: Remove _GrowableList.from which was never called. (Closed)

Created:
4 years, 5 months ago by Vyacheslav Egorov (Google)

Modified:
4 years, 5 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Remove _GrowableList.from which was never called. It contained a bug anyway: _GrowableList does not have a 0 arguments constructor. R=fschneider@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2a8581a238a2d571aa3c087f4b90a8b8761eb0f6

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	runtime/lib/growable_array.dart	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 4 (1 generated)

Vyacheslav Egorov (Google)

4 years, 5 months ago (2016-07-21 14:13:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2a8581a238a2d571aa3c087f4b90a8b8761eb0f6 (presubmit successful).