Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2163173002: [turbofan] In the feedback refinement retyper, always intersect the upper bound with the type. (Closed)

Created:
4 years, 5 months ago by Jarin
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] In the feedback refinement retyper, always intersect the upper bound with the type. BUG=chromium:608617 Committed: https://crrev.com/1906e88d3b831931340a16be9cd2d6dd622ce4bc Cr-Commit-Position: refs/heads/master@{#37890}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/compiler/simplified-lowering.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Jarin
Could you take a look, please?
4 years, 5 months ago (2016-07-20 07:09:02 UTC) #4
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-07-20 07:09:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163173002/1
4 years, 5 months ago (2016-07-20 08:45:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 08:47:44 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 08:49:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1906e88d3b831931340a16be9cd2d6dd622ce4bc
Cr-Commit-Position: refs/heads/master@{#37890}

Powered by Google App Engine
This is Rietveld 408576698