Don't test Cmd+Alt+v in the Omnibox on macOS Sierra

chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdio.h>
 
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/scoped_observer.h"
@@ skipping 36 matching lines @@
 #include "components/toolbar/test_toolbar_model.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/web_contents.h"
 #include "net/dns/mock_host_resolver.h"
 #include "ui/base/clipboard/clipboard.h"
 #include "ui/base/clipboard/scoped_clipboard_writer.h"
 #include "ui/events/event_constants.h"
 #include "ui/events/keycodes/keyboard_codes.h"
 #include "ui/gfx/geometry/point.h"
 
+#if defined(OS_MACOSX)
+#include "base/mac/mac_util.h"
+#endif
+
 using base::ASCIIToUTF16;
 using base::UTF16ToUTF8;
 using base::Time;
 using base::TimeDelta;
 using bookmarks::BookmarkModel;
 
 namespace {
 
 const char kSearchKeyword[] = "foo";
 const char kSearchKeyword2[] = "footest.com";
@@ skipping 1560 matching lines @@
   omnibox_view->CloseOmniboxPopup();
   EXPECT_FALSE(popup_model->IsOpen());
 
   // Pasting amid text should yield the expected text and re-open the popup.
   omnibox_view->SetWindowTextAndCaretPos(ASCIIToUTF16("abcd"), 2, false, false);
   SetClipboardText(ASCIIToUTF16("123"));
   ASSERT_NO_FATAL_FAILURE(SendKey(ui::VKEY_V, kCtrlOrCmdMask));
   EXPECT_EQ(ASCIIToUTF16("ab123cd"), omnibox_view->GetText());
   EXPECT_TRUE(popup_model->IsOpen());
 
-  // Ctrl/Cmd+Alt+V should not paste.
-  ASSERT_NO_FATAL_FAILURE(
-      SendKey(ui::VKEY_V, kCtrlOrCmdMask | ui::EF_ALT_DOWN));
-  EXPECT_EQ(ASCIIToUTF16("ab123cd"), omnibox_view->GetText());
+  bool run_alt_paste_test = true;
+#if defined(OS_MACOSX) && MAC_OS_X_VERSION_MIN_REQUIRED == MAC_OS_X_VERSION_10_7
+  // On macOS 10.12 Sierra Cmd+Alt+v actually does paste due to an OS bug. In
+  // addition, the synthetic test event causes a segfault inside AppKit. A real,
+  // keyboard-generated event does not crash (but incorrectly pastes). Revisit
+  // this when bumping the deployment target. See http://crbug.com/629595.
+  run_alt_paste_test = !base::mac::IsOSLaterThanElCapitan_DontCallThis();
+#endif
+  if (run_alt_paste_test) {
+    // Ctrl/Cmd+Alt+V should not paste.
+    ASSERT_NO_FATAL_FAILURE(
+        SendKey(ui::VKEY_V, kCtrlOrCmdMask | ui::EF_ALT_DOWN));
+    EXPECT_EQ(ASCIIToUTF16("ab123cd"), omnibox_view->GetText());
+  }
   // TODO(msw): Test that AltGr+V does not paste.
 }
 
 IN_PROC_BROWSER_TEST_F(OmniboxViewTest, CopyURLToClipboard) {
   // Set permanent text thus making sure that omnibox treats 'google.com'
   // as URL (not as ordinary user input).
   TestToolbarModel* test_toolbar_model = new TestToolbarModel;
   std::unique_ptr<ToolbarModel> toolbar_model(test_toolbar_model);
   test_toolbar_model->set_text(ASCIIToUTF16("http://www.google.com/"));
   browser()->swap_toolbar_models(&toolbar_model);
@@ skipping 337 matching lines @@
 
   // Now Shift+Right should do nothing, and Shift+Left should reduce.
   // At the end, so Shift+Right should do nothing.
   ASSERT_NO_FATAL_FAILURE(SendKey(ui::VKEY_RIGHT, ui::EF_SHIFT_DOWN));
   EXPECT_EQ(2u, GetSelectionSize(omnibox_view));
 
   // And Left should reduce by one character.
   ASSERT_NO_FATAL_FAILURE(SendKey(ui::VKEY_LEFT, ui::EF_SHIFT_DOWN));
   EXPECT_EQ(1u, GetSelectionSize(omnibox_view));
 }