Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2163133002: Move CPDF_Annot and CPDF_AnnotList to their own header. (Closed)

Created:
4 years, 5 months ago by jaepark
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com, dsinclair
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move CPDF_Annot and CPDF_AnnotList to their own header. Committed: https://pdfium.googlesource.com/pdfium/+/3b6c7e9669df2545fc3b19d9f03364c1040a5ab0

Patch Set 1 #

Total comments: 4

Patch Set 2 : Move CPDF_Annot and CPDF_AnnotList to their own header. #

Total comments: 4

Patch Set 3 : Move CPDF_Annot and CPDF_AnnotList to their own headers. #

Total comments: 4

Patch Set 4 : Move CPDF_Annot and CPDF_AnnotList to their own headers. #

Total comments: 2

Patch Set 5 : Move CPDF_Annot and CPDF_AnnotList to their own headers. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -556 lines) Patch
M BUILD.gn View 1 2 2 chunks +4 lines, -1 line 0 comments Download
A core/fpdfdoc/cpdf_annot.h View 1 2 1 chunk +70 lines, -0 lines 0 comments Download
A + core/fpdfdoc/cpdf_annot.cpp View 1 2 1 chunk +3 lines, -110 lines 0 comments Download
A core/fpdfdoc/cpdf_annotlist.h View 1 2 3 1 chunk +64 lines, -0 lines 0 comments Download
A core/fpdfdoc/cpdf_annotlist.cpp View 1 2 3 4 1 chunk +132 lines, -0 lines 0 comments Download
D core/fpdfdoc/doc_annot.cpp View 1 2 1 chunk +0 lines, -355 lines 0 comments Download
M core/fpdfdoc/include/fpdf_doc.h View 1 2 3 chunks +2 lines, -89 lines 0 comments Download
M pdfium.gyp View 1 2 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 20 (8 generated)
jaepark
4 years, 5 months ago (2016-07-20 01:22:01 UTC) #2
Lei Zhang
https://codereview.chromium.org/2163133002/diff/1/core/fpdfdoc/doc_annot.cpp File core/fpdfdoc/doc_annot.cpp (right): https://codereview.chromium.org/2163133002/diff/1/core/fpdfdoc/doc_annot.cpp#newcode15 core/fpdfdoc/doc_annot.cpp:15: #include "core/fpdfdoc/doc_annot.h" This goes first, with a blank line ...
4 years, 5 months ago (2016-07-20 01:34:07 UTC) #3
jaepark
https://codereview.chromium.org/2163133002/diff/1/core/fpdfdoc/doc_annot.cpp File core/fpdfdoc/doc_annot.cpp (right): https://codereview.chromium.org/2163133002/diff/1/core/fpdfdoc/doc_annot.cpp#newcode15 core/fpdfdoc/doc_annot.cpp:15: #include "core/fpdfdoc/doc_annot.h" On 2016/07/20 01:34:07, Lei Zhang wrote: > ...
4 years, 5 months ago (2016-07-20 02:29:52 UTC) #4
dsinclair
https://codereview.chromium.org/2163133002/diff/20001/core/fpdfdoc/doc_annot.h File core/fpdfdoc/doc_annot.h (right): https://codereview.chromium.org/2163133002/diff/20001/core/fpdfdoc/doc_annot.h#newcode1 core/fpdfdoc/doc_annot.h:1: // Copyright 2016 PDFium Authors. All rights reserved. This ...
4 years, 5 months ago (2016-07-20 13:25:37 UTC) #6
jaepark
Additionally, I also separated the CPDF_Annot and CPDF_AnnotList implementation files, and renamed them to cpdf_annot.cpp, ...
4 years, 5 months ago (2016-07-20 19:13:26 UTC) #7
dsinclair
https://codereview.chromium.org/2163133002/diff/40001/core/fpdfdoc/cpdf_annotlist.cpp File core/fpdfdoc/cpdf_annotlist.cpp (right): https://codereview.chromium.org/2163133002/diff/40001/core/fpdfdoc/cpdf_annotlist.cpp#newcode112 core/fpdfdoc/cpdf_annotlist.cpp:112: if (dwAnnotFlags & 0x01) { Is this ANNOTFLAG_INVISIBLE? https://codereview.chromium.org/2163133002/diff/40001/core/fpdfdoc/cpdf_annotlist.cpp#newcode116 ...
4 years, 5 months ago (2016-07-20 19:19:23 UTC) #8
jaepark
https://codereview.chromium.org/2163133002/diff/40001/core/fpdfdoc/cpdf_annotlist.cpp File core/fpdfdoc/cpdf_annotlist.cpp (right): https://codereview.chromium.org/2163133002/diff/40001/core/fpdfdoc/cpdf_annotlist.cpp#newcode112 core/fpdfdoc/cpdf_annotlist.cpp:112: if (dwAnnotFlags & 0x01) { On 2016/07/20 19:19:22, dsinclair ...
4 years, 5 months ago (2016-07-20 20:45:32 UTC) #9
dsinclair
https://codereview.chromium.org/2163133002/diff/60001/core/fpdfdoc/cpdf_annotlist.cpp File core/fpdfdoc/cpdf_annotlist.cpp (right): https://codereview.chromium.org/2163133002/diff/60001/core/fpdfdoc/cpdf_annotlist.cpp#newcode129 core/fpdfdoc/cpdf_annotlist.cpp:129: bShowWidget ? ANNOTFLAG_INVISIBLE | ANNOTFLAG_HIDDEN : ANNOTFLAG_HIDDEN; This was ...
4 years, 5 months ago (2016-07-20 20:48:07 UTC) #10
jaepark
https://codereview.chromium.org/2163133002/diff/60001/core/fpdfdoc/cpdf_annotlist.cpp File core/fpdfdoc/cpdf_annotlist.cpp (right): https://codereview.chromium.org/2163133002/diff/60001/core/fpdfdoc/cpdf_annotlist.cpp#newcode129 core/fpdfdoc/cpdf_annotlist.cpp:129: bShowWidget ? ANNOTFLAG_INVISIBLE | ANNOTFLAG_HIDDEN : ANNOTFLAG_HIDDEN; On 2016/07/20 ...
4 years, 5 months ago (2016-07-20 20:54:00 UTC) #11
dsinclair
lgtm
4 years, 5 months ago (2016-07-20 20:56:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163133002/80001
4 years, 5 months ago (2016-07-20 21:17:49 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 21:18:09 UTC) #20
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/3b6c7e9669df2545fc3b19d9f03364c1040a...

Powered by Google App Engine
This is Rietveld 408576698