Issue 216313002: Introduce ASSERT_ENABLED macro.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 216313002: Introduce ASSERT_ENABLED macro. (Closed)

Created:
6 years, 9 months ago by tkent

Modified:
6 years, 9 months ago

Reviewers:
Kunihiko Sakamoto

CC:
blink-reviews, sof, eae+blinkwatch, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, Inactive, Mikhail, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Introduce ASSERT_ENABLED macro. We have ASSERT_DISABLED macro, and it is typically used as #if !ASSERT_DISABLED ... #endif Double negative is not good for readability. We can write it with ASSERT_ENABLED as following: #if ASSERT_ENABLED ... #endif TEST=none; no behavior changes BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170280

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -9 lines)			Patch
M	Source/core/dom/TreeShared.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/wtf/Assertions.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/wtf/BloomFilter.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/wtf/DateMath.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/wtf/StringHasher.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/wtf/ThreadRestrictionVerifier.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/216313002/1

6 years, 9 months ago (2014-03-28 05:31:01 UTC) #4

Message was sent while issue was closed.

Change committed as 170280

Expand Messages | Collapse Messages