MD Settings: Remove remnants of obsolete Full Screen top-level category.

chrome/browser/resources/settings/search_settings.js

Index: chrome/browser/resources/settings/search_settings.js
diff --git a/chrome/browser/resources/settings/search_settings.js b/chrome/browser/resources/settings/search_settings.js
index c328fe89c081a90e986389b256e2bc03e3260196..511acbd20de6b4dcddf12218552c983c7cb346d8 100644
--- a/chrome/browser/resources/settings/search_settings.js
+++ b/chrome/browser/resources/settings/search_settings.js
@@ -100,18 +100,12 @@ cr.define('settings', function() {
   /**
    * Checks whether the given |node| requires force rendering.
    *
-   * @param {!SearchContext} context
    * @param {!Node} node
    * @return {boolean} Whether a forced rendering task was scheduled.
    * @private
    */
-  function forceRenderNeeded_(context, node) {
-    if (node.nodeName != 'TEMPLATE' || !node.hasAttribute('name') || node.if)
-      return false;
-
-    // TODO(dpapad): Temporarily ignore site-settings because it throws an
-    // assertion error during force-rendering.
-    return node.getAttribute('name').indexOf('site-') != 0;
+  function forceRenderNeeded_(node) {

[Dan Beam, 2016/07/20 18:03:37]

i don't think this function is required, I think you'd inflate this file less by
doing something like

var needsRender =
    node.nodeName == 'TEMPLATE' && node.hasAttribute('name') && !node.if;
if (needsRender) {

or just

if (node.nodeName == 'TEMPLATE' && node.hasAttribute('name') && !node.if) {

[dpapad, 2016/07/20 18:22:05]

Done.

+    return node.nodeName == 'TEMPLATE' && node.hasAttribute('name') && !node.if;
   }
 
   /**
@@ -126,7 +120,7 @@ cr.define('settings', function() {
    */
   function findAndHighlightMatches_(context, root) {
     function doSearch(node) {
-      if (forceRenderNeeded_(context, node)) {
+      if (forceRenderNeeded_(node)) {
         getSearchManager().queue_.addRenderTask(
             new RenderTask(context, node));
         return;