MD Settings: Remove remnants of obsolete Full Screen top-level category.

chrome/browser/resources/settings/search_settings.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @typedef {{id: number, rawQuery: ?string, regExp: ?RegExp}} */
 var SearchContext;
 
 cr.define('settings', function() {
   /** @const {string} */
   var WRAPPER_CSS_CLASS = 'search-highlight-wrapper';
@@ skipping 82 matching lines @@
         span.style.backgroundColor = 'yellow';
         span.textContent = tokens[i];
         wrapper.appendChild(span);
       }
     }
   }
 
   /**
    * Checks whether the given |node| requires force rendering.
    *
-   * @param {!SearchContext} context
    * @param {!Node} node
    * @return {boolean} Whether a forced rendering task was scheduled.
    * @private
    */
-  function forceRenderNeeded_(context, node) {
-    if (node.nodeName != 'TEMPLATE' || !node.hasAttribute('name') || node.if)
-      return false;
-
-    // TODO(dpapad): Temporarily ignore site-settings because it throws an
-    // assertion error during force-rendering.
-    return node.getAttribute('name').indexOf('site-') != 0;
+  function forceRenderNeeded_(node) {

[Dan Beam, 2016/07/20 18:03:37]

i don't think this function is required, I think you'd inflate this file less by
doing something like

var needsRender =
    node.nodeName == 'TEMPLATE' && node.hasAttribute('name') && !node.if;
if (needsRender) {

or just

if (node.nodeName == 'TEMPLATE' && node.hasAttribute('name') && !node.if) {

[dpapad, 2016/07/20 18:22:05]

Done.

+    return node.nodeName == 'TEMPLATE' && node.hasAttribute('name') && !node.if;
   }
 
   /**
    * Traverses the entire DOM (including Shadow DOM), finds text nodes that
    * match the given regular expression and applies the highlight UI. It also
    * ensures that <settings-section> instances become visible if any matches
    * occurred under their subtree.
    *
    * @param {!SearchContext} context
    * @param {!Node} root The root of the sub-tree to be searched
    * @private
    */
   function findAndHighlightMatches_(context, root) {
     function doSearch(node) {
-      if (forceRenderNeeded_(context, node)) {
+      if (forceRenderNeeded_(node)) {
         getSearchManager().queue_.addRenderTask(
             new RenderTask(context, node));
         return;
       }
 
       if (IGNORED_ELEMENTS.has(node.nodeName))
         return;
 
       if (node.nodeType == Node.TEXT_NODE) {
         var textContent = node.nodeValue.trim();
@@ skipping 307 matching lines @@
 
   /** @return {!SearchManager} */
   function getSearchManager() {
     return SearchManager.getInstance();
   }
 
   return {
     getSearchManager: getSearchManager,
   };
 });