Use smart pointers for graphics device classes

Use smart pointers for graphics device classes

Use unique_ptr for class owned member variables. Also clean up some
style issues such as removing unused functions and casting to raw pointer.

BUG=pdfium:518
Committed: https://pdfium.googlesource.com/pdfium/+/c38cd6eb274429a5755e04d2e22a606375851717

[Wei Li, 2016-07-20 00:32:49]

Description was changed from

==========
Use smart pointers for graphics devices

Use unique_ptr for class owned member variables. Also clean up some
style issues.

BUG=pdfium:518
==========

to

==========
Use smart pointers for graphics device classes

Use unique_ptr for class owned member variables. Also clean up some
style issues.

BUG=pdfium:518
==========

[Wei Li, 2016-07-20 01:00:46]

Patchset #2 (id:20001) has been deleted

[Wei Li, 2016-07-20 01:00:52]

Patchset #1 (id:1) has been deleted

[Wei Li, 2016-07-20 18:59:11]

Patchset #2 (id:60001) has been deleted

[Wei Li, 2016-07-20 22:08:14]

Patchset #5 (id:140001) has been deleted

[Wei Li, 2016-07-20 22:40:48]

Description was changed from

==========
Use smart pointers for graphics device classes

Use unique_ptr for class owned member variables. Also clean up some
style issues.

BUG=pdfium:518
==========

to

==========
Use smart pointers for graphics device classes

Use unique_ptr for class owned member variables. Also clean up some
style issues such as removing unused functions and casting to raw pointer.

BUG=pdfium:518
==========

[Wei Li, 2016-07-20 22:42:00]

weili@chromium.org changed reviewers:
+ thestig@chromium.org

[Wei Li, 2016-07-20 22:42:00]

pls review, thanks

[Lei Zhang, 2016-07-20 23:00:57]

Maybe double check and make sure we are not breaking the build with Skia?

[Lei Zhang, 2016-07-20 23:09:19]

lgtm

https://codereview.chromium.org/2163103002/diff/120001/core/fpdfapi/fpdf_rend...
File core/fpdfapi/fpdf_render/render_int.h (right):

https://codereview.chromium.org/2163103002/diff/120001/core/fpdfapi/fpdf_rend...
core/fpdfapi/fpdf_render/render_int.h:622: void
TranslateScanline(std::vector<uint8_t>* dest_buf,
Can we flip the parameters so the in-param comes before the out-param? (Maybe
another CL)

https://codereview.chromium.org/2163103002/diff/120001/core/fxge/dib/fx_dib_m...
File core/fxge/dib/fx_dib_main.cpp (right):

https://codereview.chromium.org/2163103002/diff/120001/core/fxge/dib/fx_dib_m...
core/fxge/dib/fx_dib_main.cpp:1501: return &m_pScanline[0];
Can we return m_pScanline.data() ?

https://codereview.chromium.org/2163103002/diff/120001/core/fxge/include/fx_d...
File core/fxge/include/fx_dib.h (right):

https://codereview.chromium.org/2163103002/diff/120001/core/fxge/include/fx_d...
core/fxge/include/fx_dib.h:424: mutable std::vector<uint8_t> m_pScanline;
No longer a pointer, so the 'p' needs to go?

https://codereview.chromium.org/2163103002/diff/120001/core/fxge/include/fx_ge.h
File core/fxge/include/fx_ge.h (right):

https://codereview.chromium.org/2163103002/diff/120001/core/fxge/include/fx_g...
core/fxge/include/fx_ge.h:217: // Take ownership of |pDriver|.
Can we change the parameter to std::unique_ptr?

[Wei Li, 2016-07-21 16:47:07]

thanks, made the changes.

https://codereview.chromium.org/2163103002/diff/120001/core/fpdfapi/fpdf_rend...
File core/fpdfapi/fpdf_render/render_int.h (right):

https://codereview.chromium.org/2163103002/diff/120001/core/fpdfapi/fpdf_rend...
core/fpdfapi/fpdf_render/render_int.h:622: void
TranslateScanline(std::vector<uint8_t>* dest_buf,
On 2016/07/20 23:09:19, Lei Zhang wrote:
> Can we flip the parameters so the in-param comes before the out-param? (Maybe
> another CL)

Done.

https://codereview.chromium.org/2163103002/diff/120001/core/fxge/dib/fx_dib_m...
File core/fxge/dib/fx_dib_main.cpp (right):

https://codereview.chromium.org/2163103002/diff/120001/core/fxge/dib/fx_dib_m...
core/fxge/dib/fx_dib_main.cpp:1501: return &m_pScanline[0];
On 2016/07/20 23:09:19, Lei Zhang wrote:
> Can we return m_pScanline.data() ?

Done.

https://codereview.chromium.org/2163103002/diff/120001/core/fxge/include/fx_d...
File core/fxge/include/fx_dib.h (right):

https://codereview.chromium.org/2163103002/diff/120001/core/fxge/include/fx_d...
core/fxge/include/fx_dib.h:424: mutable std::vector<uint8_t> m_pScanline;
On 2016/07/20 23:09:19, Lei Zhang wrote:
> No longer a pointer, so the 'p' needs to go?

Done.

https://codereview.chromium.org/2163103002/diff/120001/core/fxge/include/fx_ge.h
File core/fxge/include/fx_ge.h (right):

https://codereview.chromium.org/2163103002/diff/120001/core/fxge/include/fx_g...
core/fxge/include/fx_ge.h:217: // Take ownership of |pDriver|.
On 2016/07/20 23:09:19, Lei Zhang wrote:
> Can we change the parameter to std::unique_ptr?

Done.

[Wei Li, 2016-07-21 21:43:35]

Patchset #7 (id:200001) has been deleted

[Wei Li, 2016-07-21 21:43:46]

The CQ bit was checked by weili@chromium.org

[Wei Li, 2016-07-21 21:43:46]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2163103002/#ps180001
(title: "fix all platforms")

[commit-bot: I haz the power, 2016-07-21 21:43:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 21:44:20]

Description was changed from

==========
Use smart pointers for graphics device classes

Use unique_ptr for class owned member variables. Also clean up some
style issues such as removing unused functions and casting to raw pointer.

BUG=pdfium:518
==========

to

==========
Use smart pointers for graphics device classes

Use unique_ptr for class owned member variables. Also clean up some
style issues such as removing unused functions and casting to raw pointer.

BUG=pdfium:518

Committed:
https://pdfium.googlesource.com/pdfium/+/c38cd6eb274429a5755e04d2e22a60637585...
==========

[commit-bot: I haz the power, 2016-07-21 21:44:21]

Committed patchset #6 (id:180001) as
https://pdfium.googlesource.com/pdfium/+/c38cd6eb274429a5755e04d2e22a60637585...