third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js - Issue 2163093003: [DevTools] Remove Object.values and Object.isEmpty from utilities.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 2163093003: [DevTools] Remove Object.values and Object.isEmpty from utilities.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/snippets/SnippetStorage.js ('K') | « third_party/WebKit/Source/devtools/front_end/snippets/SnippetStorage.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js » ('j') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

index f7154e4d5b11623345cafcc006cbabc6a3095275..b0c430e7e2f62b789a1bee8049bc1f0d3546f712 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

@@ -554,7 +554,7 @@ WebInspector.TimelineFlameChartDataProvider.prototype = {

_appendAsyncEvents: function(asyncEvents)

{

var groups = WebInspector.TimelineModel.AsyncEventGroup;

- var groupArray = Object.values(groups);

+ var groupArray = Object.keys(groups).map(key => groups[key]);

groupArray.remove(groups.animation);

groupArray.remove(groups.input);