Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 2163093003: [DevTools] Remove Object.values and Object.isEmpty from utilities.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 536 matching lines...) Expand 10 before | Expand all | Expand 10 after
547 { 547 {
548 return WebInspector.blackboxManager.isBlackboxedURL(url); 548 return WebInspector.blackboxManager.isBlackboxedURL(url);
549 }, 549 },
550 550
551 /** 551 /**
552 * @param {!Map<!WebInspector.TimelineModel.AsyncEventGroup, !Array<!WebInsp ector.TracingModel.AsyncEvent>>} asyncEvents 552 * @param {!Map<!WebInspector.TimelineModel.AsyncEventGroup, !Array<!WebInsp ector.TracingModel.AsyncEvent>>} asyncEvents
553 */ 553 */
554 _appendAsyncEvents: function(asyncEvents) 554 _appendAsyncEvents: function(asyncEvents)
555 { 555 {
556 var groups = WebInspector.TimelineModel.AsyncEventGroup; 556 var groups = WebInspector.TimelineModel.AsyncEventGroup;
557 var groupArray = Object.values(groups); 557 var groupArray = Object.keys(groups).map(key => groups[key]);
558 558
559 groupArray.remove(groups.animation); 559 groupArray.remove(groups.animation);
560 groupArray.remove(groups.input); 560 groupArray.remove(groups.input);
561 561
562 for (var groupIndex = 0; groupIndex < groupArray.length; ++groupIndex) { 562 for (var groupIndex = 0; groupIndex < groupArray.length; ++groupIndex) {
563 var group = groupArray[groupIndex]; 563 var group = groupArray[groupIndex];
564 var events = asyncEvents.get(group); 564 var events = asyncEvents.get(group);
565 if (events) { 565 if (events) {
566 var title = WebInspector.TimelineUIUtils.titleForAsyncEventGroup (groups.input); 566 var title = WebInspector.TimelineUIUtils.titleForAsyncEventGroup (groups.input);
567 this._appendAsyncEventsGroup(title, events, this._headerLevel1); 567 this._appendAsyncEventsGroup(title, events, this._headerLevel1);
(...skipping 948 matching lines...) Expand 10 before | Expand all | Expand 10 after
1516 /** 1516 /**
1517 * @constructor 1517 * @constructor
1518 * @param {!WebInspector.TimelineSelection} selection 1518 * @param {!WebInspector.TimelineSelection} selection
1519 * @param {number} entryIndex 1519 * @param {number} entryIndex
1520 */ 1520 */
1521 WebInspector.TimelineFlameChartView.Selection = function(selection, entryIndex) 1521 WebInspector.TimelineFlameChartView.Selection = function(selection, entryIndex)
1522 { 1522 {
1523 this.timelineSelection = selection; 1523 this.timelineSelection = selection;
1524 this.entryIndex = entryIndex; 1524 this.entryIndex = entryIndex;
1525 } 1525 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698