[DevTools] Remove Object.values and Object.isEmpty from utilities.js

third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 1138 matching lines @@
     invalidationsTreeOutline.element.classList.add("invalidations-tree");
 
     var invalidationGroups = groupInvalidationsByCause(invalidations);
     invalidationGroups.forEach(function(group) {
         var groupElement = new WebInspector.TimelineUIUtils.InvalidationsGroupElement(target, relatedNodesMap, contentHelper, group);
         invalidationsTreeOutline.appendChild(groupElement);
     });
     contentHelper.appendElementRow(title, invalidationsTreeOutline.element, false, true);
 
     /**
-     * @param {!Array.<!WebInspector.InvalidationTrackingEvent>} invalidations
+     * @param {!Array<!WebInspector.InvalidationTrackingEvent>} invalidations
+     * @return {!Array<!Array<!WebInspector.InvalidationTrackingEvent>>}
      */
     function groupInvalidationsByCause(invalidations)
     {
-        var causeToInvalidationMap = {};
+        /** @type {!Map<string, !Array<!WebInspector.InvalidationTrackingEvent>>} */
+        var causeToInvalidationMap = new Map();
         for (var index = 0; index < invalidations.length; index++) {
             var invalidation = invalidations[index];
             var causeKey = "";
             if (invalidation.cause.reason)
                 causeKey += invalidation.cause.reason + ".";
             if (invalidation.cause.stackTrace) {
                 invalidation.cause.stackTrace.forEach(function(stackFrame) {
                     causeKey += stackFrame["functionName"] + ".";
                     causeKey += stackFrame["scriptId"] + ".";
                     causeKey += stackFrame["url"] + ".";
                     causeKey += stackFrame["lineNumber"] + ".";
                     causeKey += stackFrame["columnNumber"] + ".";
                 });
             }
 
-            if (causeToInvalidationMap[causeKey])
-                causeToInvalidationMap[causeKey].push(invalidation);
+            if (causeToInvalidationMap.has(causeKey))
+                causeToInvalidationMap.get(causeKey).push(invalidation);
             else
-                causeToInvalidationMap[causeKey] = [ invalidation ];
+                causeToInvalidationMap.set(causeKey, [ invalidation ]);
         }
-        return Object.values(causeToInvalidationMap);
+        return Array.from(causeToInvalidationMap.values());

[lushnikov, 2016/07/20 03:02:50]

valuesArray

[kozy, 2016/07/20 17:55:19]

Done.

     }
 }
 
 /**
  * @param {!Set<number>} nodeIds
  * @param {!WebInspector.InvalidationTrackingEvent} invalidations
  */
 WebInspector.TimelineUIUtils._collectInvalidationNodeIds = function(nodeIds, invalidations)
 {
     for (var i = 0; i < invalidations.length; ++i) {
@@ skipping 955 matching lines @@
     case warnings.V8Deopt:
         span.appendChild(WebInspector.linkifyURLAsNode("https://github.com/GoogleChrome/devtools-docs/issues/53",
             WebInspector.UIString("Not optimized"), undefined, true));
         span.createTextChild(WebInspector.UIString(": %s", eventData["deoptReason"]));
         break;
     default:
         console.assert(false, "Unhandled TimelineModel.WarningType");
     }
     return span;
 }