[DevTools] Remove Object.values and Object.isEmpty from utilities.js

third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js

 /*
  * Copyright 2014 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /**
  * @constructor
  * @param {!WebInspector.BackingStorage} backingStorage
  */
@@ skipping 142 matching lines @@
         for (var i = 0; i < events.length; ++i)
             this._addEvent(events[i]);
     },
 
     tracingComplete: function()
     {
         this._processPendingAsyncEvents();
         this._backingStorage.appendString(this._firstWritePending ? "[]" : "]");
         this._backingStorage.finishWriting();
         this._firstWritePending = false;
-        for (var process of Object.values(this._processById)) {
-            for (var thread of Object.values(process._threads))
+        for (var process of this._processById.values()) {
+            for (var thread of process._threads.values())
                 thread.tracingComplete();
         }
     },
 
     reset: function()
     {
-        /** @type {!Object.<(number|string), !WebInspector.TracingModel.Process>} */
-        this._processById = {};
+        /** @type {!Map<(number|string), !WebInspector.TracingModel.Process>} */
+        this._processById = new Map();
         this._processByName = new Map();
         this._minimumRecordTime = 0;
         this._maximumRecordTime = 0;
         this._devToolsMetadataEvents = [];
         if (!this._firstWritePending)
             this._backingStorage.reset();
 
         this._firstWritePending = true;
         /** @type {!Array<!WebInspector.TracingModel.Event>} */
         this._asyncEvents = [];
         /** @type {!Map<string, !WebInspector.TracingModel.AsyncEvent>} */
         this._openAsyncEvents = new Map();
         /** @type {!Map<string, !Array<!WebInspector.TracingModel.AsyncEvent>>} */
         this._openNestableAsyncEvents = new Map();
         /** @type {!Map<string, !Set<string>>} */
         this._parsedCategories = new Map();
     },
 
     /**
       * @param {!WebInspector.TracingManager.EventPayload} payload
       */
     _addEvent: function(payload)
     {
-        var process = this._processById[payload.pid];
+        var process = this._processById.get(payload.pid);
         if (!process) {
             process = new WebInspector.TracingModel.Process(this, payload.pid);
-            this._processById[payload.pid] = process;
+            this._processById.set(payload.pid, process);
         }
 
         var eventsDelimiter = ",\n";
         this._backingStorage.appendString(this._firstWritePending ? "[" : eventsDelimiter);
         this._firstWritePending = false;
         var stringPayload = JSON.stringify(payload);
         var isAccessible = payload.ph === WebInspector.TracingModel.Phase.SnapshotObject;
         var backingStorage = null;
         var keepStringsLessThan = 10000;
         if (isAccessible && stringPayload.length > keepStringsLessThan)
@@ skipping 55 matching lines @@
     maximumRecordTime: function()
     {
         return this._maximumRecordTime;
     },
 
     /**
      * @return {!Array.<!WebInspector.TracingModel.Process>}
      */
     sortedProcesses: function()
     {
-        return WebInspector.TracingModel.NamedObject._sort(Object.values(this._processById));
+        return WebInspector.TracingModel.NamedObject._sort(Array.from(this._processById.values()));

[lushnikov, 2016/07/20 03:02:50]

valuesArray

[kozy, 2016/07/20 17:55:18]

Done.

     },
 
     /**
      * @param {string} name
      * @return {?WebInspector.TracingModel.Process}
      */
     processByName: function(name)
     {
         return this._processByName.get(name);
     },
@@ skipping 457 matching lines @@
  * @constructor
  * @extends {WebInspector.TracingModel.NamedObject}
  * @param {!WebInspector.TracingModel} model
  * @param {number} id
  */
 WebInspector.TracingModel.Process = function(model, id)
 {
     WebInspector.TracingModel.NamedObject.call(this);
     this._setName("Process " + id);
     this._id = id;
-    /** @type {!Object.<number, !WebInspector.TracingModel.Thread>} */
-    this._threads = {};
+    /** @type {!Map<number, !WebInspector.TracingModel.Thread>} */
+    this._threads = new Map();
     this._threadByName = new Map();
     this._model = model;
 }
 
 WebInspector.TracingModel.Process.prototype = {
     /**
      * @return {number}
      */
     id: function()
     {
         return this._id;
     },
 
     /**
      * @param {number} id
      * @return {!WebInspector.TracingModel.Thread}
      */
     threadById: function(id)
     {
-        var thread = this._threads[id];
+        var thread = this._threads.get(id);
         if (!thread) {
             thread = new WebInspector.TracingModel.Thread(this, id);
-            this._threads[id] = thread;
+            this._threads.set(id, thread);
         }
         return thread;
     },
 
     /**
      * @param {string} name
      * @return {?WebInspector.TracingModel.Thread}
      */
     threadByName: function(name)
     {
@@ skipping 16 matching lines @@
     _addEvent: function(payload)
     {
         return this.threadById(payload.tid)._addEvent(payload);
     },
 
     /**
      * @return {!Array.<!WebInspector.TracingModel.Thread>}
      */
     sortedThreads: function()
     {
-        return WebInspector.TracingModel.NamedObject._sort(Object.values(this._threads));
+        return WebInspector.TracingModel.NamedObject._sort(Array.from(this._threads.values()));

[lushnikov, 2016/07/20 03:02:50]

valuesArray

[kozy, 2016/07/20 17:55:18]

Done.

     },
 
     __proto__: WebInspector.TracingModel.NamedObject.prototype
 }
 
 /**
  * @constructor
  * @extends {WebInspector.TracingModel.NamedObject}
  * @param {!WebInspector.TracingModel.Process} process
  * @param {number} id
@@ skipping 103 matching lines @@
     /**
      * @return {!Array.<!WebInspector.TracingModel.AsyncEvent>}
      */
     asyncEvents: function()
     {
         return this._asyncEvents;
     },
 
     __proto__: WebInspector.TracingModel.NamedObject.prototype
 }