[DevTools] Remove Object.values and Object.isEmpty from utilities.js

third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 23 matching lines @@
  * @param {!WebInspector.Target} target
  */
 WebInspector.RuntimeModel = function(target)
 {
     WebInspector.SDKModel.call(this, WebInspector.RuntimeModel, target);
 
     this._agent = target.runtimeAgent();
     this.target().registerRuntimeDispatcher(new WebInspector.RuntimeDispatcher(this));
     if (target.hasJSCapability())
         this._agent.enable();
-    /**
-     * @type {!Object.<number, !WebInspector.ExecutionContext>}
-     */
-    this._executionContextById = {};
+    /** @type {!Map<number, !WebInspector.ExecutionContext>} */
+    this._executionContextById = new Map();
     this._executionContextComparator = WebInspector.ExecutionContext.comparator;
 
     if (WebInspector.moduleSetting("customFormatters").get())
         this._agent.setCustomObjectFormatterEnabled(true);
 
     WebInspector.moduleSetting("customFormatters").addChangeListener(this._customFormattersStateChanged.bind(this));
 }
 
 WebInspector.RuntimeModel.Events = {
     ExecutionContextCreated: "ExecutionContextCreated",
     ExecutionContextDestroyed: "ExecutionContextDestroyed",
     ExecutionContextChanged: "ExecutionContextChanged"
 }
 
 WebInspector.RuntimeModel._privateScript = "private script";
 
 WebInspector.RuntimeModel.prototype = {
 
     /**
      * @return {!Array.<!WebInspector.ExecutionContext>}
      */
     executionContexts: function()
     {
-        return Object.values(this._executionContextById).sort(this.executionContextComparator());
+        return Array.from(this._executionContextById.values()).sort(this.executionContextComparator());

[lushnikov, 2016/07/20 03:02:50]

valuesArray

[kozy, 2016/07/20 17:55:18]

Done.

     },
 
     /**
      * @param {function(!WebInspector.ExecutionContext,!WebInspector.ExecutionContext)} comparator
      */
     setExecutionContextComparator: function(comparator)
     {
         this._executionContextComparator = comparator;
     },
 
     /**
      * @return {function(!WebInspector.ExecutionContext,!WebInspector.ExecutionContext)} comparator
      */
     executionContextComparator: function()
     {
         return this._executionContextComparator;
     },
 
     /**
      * @return {?WebInspector.ExecutionContext}
      */
     defaultExecutionContext: function()
     {
-        for (var context of Object.values(this._executionContextById)) {
+        for (var context of this._executionContextById.values()) {
             if (context.isDefault)
                 return context;
         }
         return null;
     },
 
     /**
      * @param {!RuntimeAgent.ExecutionContextId} id
      * @return {?WebInspector.ExecutionContext}
      */
     executionContext: function(id)
     {
-        return this._executionContextById[id] || null;
+        return this._executionContextById.get(id) || null;
     },
 
     /**
      * @param {!RuntimeAgent.ExecutionContextDescription} context
      */
     _executionContextCreated: function(context)
     {
         // The private script context should be hidden behind an experiment.
         if (context.name === WebInspector.RuntimeModel._privateScript && !context.origin && !Runtime.experiments.isEnabled("privateScriptInspection")) {
             return;
         }
         var executionContext = new WebInspector.ExecutionContext(this.target(), context.id, context.name, context.origin, context.isDefault, context.frameId);
-        this._executionContextById[executionContext.id] = executionContext;
+        this._executionContextById.set(executionContext.id, executionContext);
         this.dispatchEventToListeners(WebInspector.RuntimeModel.Events.ExecutionContextCreated, executionContext);
     },
 
     /**
      * @param {number} executionContextId
      */
     _executionContextDestroyed: function(executionContextId)
     {
-        var executionContext = this._executionContextById[executionContextId];
+        var executionContext = this._executionContextById.get(executionContextId);
         if (!executionContext)
             return;
-        delete this._executionContextById[executionContextId];
+        this._executionContextById.delete(executionContextId);
         this.dispatchEventToListeners(WebInspector.RuntimeModel.Events.ExecutionContextDestroyed, executionContext);
     },
 
     _executionContextsCleared: function()
     {
         var debuggerModel = WebInspector.DebuggerModel.fromTarget(this.target());
         if (debuggerModel)
             debuggerModel.globalObjectCleared();
         var contexts = this.executionContexts();
-        this._executionContextById = {};
+        this._executionContextById.clear();
         for (var  i = 0; i < contexts.length; ++i)
             this.dispatchEventToListeners(WebInspector.RuntimeModel.Events.ExecutionContextDestroyed, contexts[i]);
     },
 
     /**
      * @param {!RuntimeAgent.RemoteObject} payload
      * @return {!WebInspector.RemoteObject}
      */
     createRemoteObject: function(payload)
     {
@@ skipping 858 matching lines @@
     /**
      * @return {boolean}
      */
     isNormalListenerType: function()
     {
         return this._listenerType === "normal";
     },
 
     __proto__: WebInspector.SDKObject.prototype
 }