Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2163093002: remove linked_ptr from gpu/ (Closed)

Created:
4 years, 5 months ago by piman
Modified:
4 years, 5 months ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

remove linked_ptr from gpu/ Because unique_ptr and move semantics are more awesome. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/22586df9c073c39ac841b1ffc895ec932f321eb7 Cr-Commit-Position: refs/heads/master@{#406728}

Patch Set 1 #

Patch Set 2 : Fix? win32 compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -31 lines) Patch
M gpu/command_buffer/client/cmd_buffer_helper_test.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/command_executor.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/common_decoder.h View 1 3 chunks +2 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/common_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/mailbox_manager_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/mailbox_manager_sync.cc View 3 chunks +8 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/texture_definition.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
piman
4 years, 5 months ago (2016-07-19 23:57:48 UTC) #5
no sievers
lgtm
4 years, 5 months ago (2016-07-20 21:19:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163093002/20001
4 years, 5 months ago (2016-07-20 22:53:27 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 00:33:39 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 00:34:45 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/22586df9c073c39ac841b1ffc895ec932f321eb7
Cr-Commit-Position: refs/heads/master@{#406728}

Powered by Google App Engine
This is Rietveld 408576698