Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: content/browser/download/docs/save-page-as.md

Issue 2163073002: Avoid crashing if MHTMLGenerationManager::JobFinished is called twice. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Posting the injection ->UI->FILE->UI. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/download/mhtml_generation_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/docs/save-page-as.md
diff --git a/content/browser/download/docs/save-page-as.md b/content/browser/download/docs/save-page-as.md
index 2661289b375a9b6a190bc0b5b75529c1acdb02fa..dba234c6425988540281f70b682e09b57ac0b9b5 100644
--- a/content/browser/download/docs/save-page-as.md
+++ b/content/browser/download/docs/save-page-as.md
@@ -88,13 +88,16 @@ Very high-level flow of saving a page as MHTML:
API) or by an embedder of `WebContents` (since this is public API of
//content).
-* Step 2: `MHTMLGenerationManager` coordinates generation of the MHTML file
- by sequentially (one-at-a-time) asking each frame to write its portion
- of MHTML to a file handle. Other classes (i.e. `SavePackage` and/or
- `SaveFileManager`) are not used at this step at all.
-
-* Step 3: When done `MHTMLGenerationManager` calls a completion callback
- which in case of Save-Page-As will end up in
+* Step 2: `MHTMLGenerationManager` creates a new instance of
+ `MHTMLGenerationManager::Job` that coordinates generation of
+ the MHTML file by sequentially (one-at-a-time) asking each
+ frame to write its portion of MHTML to a file handle. Other
+ classes (i.e. `SavePackage` and/or `SaveFileManager`) are not
+ used at this step at all.
+
+* Step 3: When done `MHTMLGenerationManager` destroys
+ `MHTMLGenerationManager::Job` instance and calls a completion
+ callback which in case of Save-Page-As will end up in
`SavePackage::OnMHTMLGenerated`.
Note: MHTML format is by default disabled in Save-Page-As UI on Windows, MacOS
« no previous file with comments | « no previous file | content/browser/download/mhtml_generation_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698