base/version.cc - Issue 2163033002: base::Version constructor from std::vector<uint32_t>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/version.cc

Issue 2163033002: base::Version constructor from std::vector<uint32_t> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes based on nit comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/version.cc

diff --git a/base/version.cc b/base/version.cc

index 02213fbf158ed56179dacf3288ab0f58bcf95c0b..ca97a842226891f35e89af861d610f7a07c292bf 100644

--- a/base/version.cc

+++ b/base/version.cc

@@ -93,6 +93,8 @@ Version::Version(const std::string& version_str) {

components_.swap(parsed);

}

+Version::Version(std::vector<uint32_t> components) : components_(components) {}

bool Version::IsValid() const {

return (!components_.empty());

}

« no previous file with comments | « base/version.h ('k') | base/version_unittest.cc » ('j') | no next file with comments »