base::Version constructor from std::vector<uint32_t>

base/version.h

Index: base/version.h
diff --git a/base/version.h b/base/version.h
index 25b570a4e3f157636cd0e22f095ff368a56a30d9..6420ccf8c7373644763a35c811fd1aad83898644 100644
--- a/base/version.h
+++ b/base/version.h
@@ -25,13 +25,18 @@ class BASE_EXPORT Version {
 
   Version(const Version& other);
 
-  ~Version();
-
   // Initializes from a decimal dotted version number, like "0.1.1".
   // Each component is limited to a uint16_t. Call IsValid() to learn
   // the outcome.
   explicit Version(const std::string& version_str);
 
+  // Initializes from a vector of components, like {1, 2, 3, 4}

[danakj, 2016/07/22 21:29:48]

Comments are sentences, including punctuation at the end.

+  // This construct is used by Version's struct traits and should be called

[danakj, 2016/07/22 21:29:48]

Can you remove this comment about rvalue vectors. People should always pass
vectors by move if appropriate.

+  // with rvalue vectors
+  explicit Version(std::vector<uint32_t> components);
+
+  ~Version();
+
   // Returns true if the object contains a valid version number.
   bool IsValid() const;