Index: base/version.h |
diff --git a/base/version.h b/base/version.h |
index 25b570a4e3f157636cd0e22f095ff368a56a30d9..42bc40dbfd2856b0778fa495d42916e5150be8c4 100644 |
--- a/base/version.h |
+++ b/base/version.h |
@@ -32,6 +32,12 @@ class BASE_EXPORT Version { |
// the outcome. |
explicit Version(const std::string& version_str); |
+ explicit Version(std::vector<uint32_t>&& components); |
danakj
2016/07/19 20:50:07
This is not a valid constructor in the style guide
Fady Samuel
2016/07/19 21:05:59
Sorry, I misguided Alex. I told him we want a move
danakj
2016/07/19 21:18:32
Right, use move if you don't want to copy. So I'm
Alex Z.
2016/07/22 13:28:03
I changed the constructor to take the vector by va
|
+ |
+ Version& operator=(Version&& other); |
+ |
danakj
2016/07/19 20:50:07
nit: you can use less whitespace and group the cop
Alex Z.
2016/07/22 13:28:03
I removed the new operator='s since they are no lo
|
+ Version& operator=(const Version& other); |
+ |
// Returns true if the object contains a valid version number. |
bool IsValid() const; |