base::Version constructor from std::vector<uint32_t>

base/version.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/version.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 
@@ skipping 62 matching lines @@
     }
   }
   return 0;
 }
 
 }  // namespace
 
 Version::Version() {
 }
 
 Version::Version(const Version& other) = default;

[danakj, 2016/07/19 20:50:07]

please order things in here to match the header when you fix ordering there

[Alex Z., 2016/07/22 13:28:03]

Done.

 
 Version::~Version() {
 }
 
 Version::Version(const std::string& version_str) {
   std::vector<uint32_t> parsed;
   if (!ParseVersionNumbers(version_str, &parsed))
     return;
 
   components_.swap(parsed);
 }
 
+Version::Version(std::vector<uint32_t>&& components)
+    : components_(components) {}
+
+Version& Version::operator=(Version&& other) {

[danakj, 2016/07/19 20:50:07]

can you just use =
default?

[Alex Z., 2016/07/22 13:28:03]

Done.

+  components_ = std::move(other.components_);
+  return *this;
+}
+
+Version& Version::operator=(const Version& other) {

[danakj, 2016/07/19 20:50:07]

ditto, =default?

[Alex Z., 2016/07/22 13:28:03]

Done.

+  components_ = other.components_;
+  return *this;
+}
+
 bool Version::IsValid() const {
   return (!components_.empty());
 }
 
 // static
 bool Version::IsValidWildcardString(const std::string& wildcard_string) {
   std::string version_string = wildcard_string;
   if (EndsWith(version_string, ".*", CompareCase::SENSITIVE))
     version_string.resize(version_string.size() - 2);
 
@@ skipping 78 matching lines @@
 
 bool operator>=(const Version& v1, const Version& v2) {
   return v1.CompareTo(v2) >= 0;
 }
 
 std::ostream& operator<<(std::ostream& stream, const Version& v) {
   return stream << v.GetString();
 }
 
 }  // namespace base