[Extensions] Ensure ordering of extension [un]loaded, activated messages

extensions/browser/renderer_startup_helper.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/renderer_startup_helper.h"
 
 #include "base/values.h"
 #include "components/keyed_service/content/browser_context_dependency_manager.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
@@ skipping 10 matching lines @@
 
 using content::BrowserContext;
 
 namespace extensions {
 
 RendererStartupHelper::RendererStartupHelper(BrowserContext* browser_context)
     : browser_context_(browser_context) {
   DCHECK(browser_context);
   registrar_.Add(this, content::NOTIFICATION_RENDERER_PROCESS_CREATED,
                  content::NotificationService::AllBrowserContextsAndSources());
+  registrar_.Add(this, content::NOTIFICATION_RENDERER_PROCESS_TERMINATED,
+                 content::NotificationService::AllBrowserContextsAndSources());
 }
 
 RendererStartupHelper::~RendererStartupHelper() {}
 
 void RendererStartupHelper::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
-  DCHECK_EQ(content::NOTIFICATION_RENDERER_PROCESS_CREATED, type);
-  content::RenderProcessHost* process =
-      content::Source<content::RenderProcessHost>(source).ptr();
+  switch (type) {
+    case content::NOTIFICATION_RENDERER_PROCESS_CREATED:
+      InitializeProcess(
+          content::Source<content::RenderProcessHost>(source).ptr());
+      break;
+    case content::NOTIFICATION_RENDERER_PROCESS_TERMINATED:
+      UntrackProcess(content::Source<content::RenderProcessHost>(source).ptr());
+      break;
+    default:
+      NOTREACHED() << "Unexpected notification: " << type;
+  }
+}
+
+void RendererStartupHelper::InitializeProcess(
+    content::RenderProcessHost* process) {
   ExtensionsBrowserClient* client = ExtensionsBrowserClient::Get();
   if (!client->IsSameContext(browser_context_, process->GetBrowserContext()))
     return;
 
   bool activity_logging_enabled =
       client->IsActivityLoggingEnabled(process->GetBrowserContext());
   // We only send the ActivityLoggingEnabled message if it is enabled; otherwise
   // the default (not enabled) is correct.
   if (activity_logging_enabled) {
     process->Send(
@@ skipping 32 matching lines @@
       // TODO(kalman): Only include tab specific permissions for extension
       // processes, no other process needs it, so it's mildly wasteful.
       // I am not sure this is possible to know this here, at such a low
       // level of the stack. Perhaps site isolation can help.
       bool include_tab_permissions = true;
       loaded_extensions.push_back(
           ExtensionMsg_Loaded_Params(ext.get(), include_tab_permissions));
     }
   }
   process->Send(new ExtensionMsg_Loaded(loaded_extensions));
+  auto iter = pending_active_extensions_.find(process);
+  if (iter != pending_active_extensions_.end()) {
+    for (const ExtensionId& id : iter->second)
+      process->Send(new ExtensionMsg_ActivateExtension(id));

[lazyboy, 2016/07/22 00:29:31]

DCHECK(extensions.Contains(id)) or does that make sense here?

[Devlin, 2016/07/26 03:45:09]

Sure, done.

+  }
+
+  initialized_processes_.insert(process);
+}
+
+void RendererStartupHelper::UntrackProcess(
+    content::RenderProcessHost* process) {
+  initialized_processes_.erase(process);

[lazyboy, 2016/07/22 00:29:31]

Though not necessary, I think bailing out of this method early when process's
context doesn't match |browser_context_| is a good idea.
For one that is the correct thing to do. The other would be to avoid unnecessary
erase calls below.

[Devlin, 2016/07/26 03:45:09]

Done.

+  pending_active_extensions_.erase(process);
+}
+
+void RendererStartupHelper::ActivateExtensionInProcess(
+    const ExtensionId& id,
+    content::RenderProcessHost* process) {
+  if (initialized_processes_.count(process))
+    process->Send(new ExtensionMsg_ActivateExtension(id));
+  else
+    pending_active_extensions_[process].insert(id);
+}
+
+void RendererStartupHelper::OnExtensionLoaded(const Extension& extension) {
+  if (extension.is_theme())

[lazyboy, 2016/07/22 00:29:31]

Retain the old comment:
// Renderers don't need to know about themes.

[Devlin, 2016/07/26 03:45:09]

Done.

+    return;
+
+  // We don't need to include tab permisisons here, since the extension
+  // was just loaded.
+  // Uninitialized renderers will be informed of the extension load during the
+  // first batch of messages.
+  std::vector<ExtensionMsg_Loaded_Params> params(
+      1,
+      ExtensionMsg_Loaded_Params(&extension, false /* no tab permissions */));
+  for (content::RenderProcessHost* process : initialized_processes_)
+    process->Send(new ExtensionMsg_Loaded(params));
+}
+
+void RendererStartupHelper::OnExtensionUnloaded(const ExtensionId& id) {
+  for (content::RenderProcessHost* process : initialized_processes_)
+    process->Send(new ExtensionMsg_Unloaded(id));
+  for (auto& kv : pending_active_extensions_)

[lazyboy, 2016/07/22 00:29:31]

s/kv/extensions_in_process or sth.

[Devlin, 2016/07/26 03:45:09]

replaced with process_extensions_pair (it's not extensions_in_process, since it
contains the key as well).  kv is my go to for map types for key-value, but I
suppose this is more legible.

+    kv.second.erase(id);
 }
 
 //////////////////////////////////////////////////////////////////////////////
 
 // static
 RendererStartupHelper* RendererStartupHelperFactory::GetForBrowserContext(
     BrowserContext* context) {
   return static_cast<RendererStartupHelper*>(
       GetInstance()->GetServiceForBrowserContext(context, true));
 }
@@ skipping 21 matching lines @@
     BrowserContext* context) const {
   // Redirected in incognito.
   return ExtensionsBrowserClient::Get()->GetOriginalContext(context);
 }
 
 bool RendererStartupHelperFactory::ServiceIsCreatedWithBrowserContext() const {
   return true;
 }
 
 }  // namespace extensions