Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: telemetry/telemetry/internal/story_runner_unittest.py

Issue 2162963002: [polymer] Merge of master into polymer10-migration (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration
Patch Set: Merge polymer10-migration int polymer10-merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/internal/story_runner.py ('k') | telemetry/telemetry/internal/util/webpagereplay.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/story_runner_unittest.py
diff --git a/telemetry/telemetry/internal/story_runner_unittest.py b/telemetry/telemetry/internal/story_runner_unittest.py
index 414f3f3997e1926965bd55ebea015de8d348280b..94d5705c5c9a38416f2979c59e0800a05217a985 100644
--- a/telemetry/telemetry/internal/story_runner_unittest.py
+++ b/telemetry/telemetry/internal/story_runner_unittest.py
@@ -363,7 +363,7 @@ class StoryRunnerTest(unittest.TestCase):
calls_in_order = GetCallsInOrder() # pylint: disable=no-value-for-parameter
self.assertEquals(EXPECTED_CALLS_IN_ORDER, calls_in_order)
- def testTearDownStateAfterEachStoryRun(self):
+ def testTearDownStateAfterEachStoryOrStorySetRun(self):
class TestSharedStateForTearDown(TestSharedState):
num_of_tear_downs = 0
@@ -384,9 +384,15 @@ class StoryRunnerTest(unittest.TestCase):
TestSharedStateForTearDown.num_of_tear_downs = 0
story_runner.Run(mock.MagicMock(), story_set, self.options, self.results,
- should_tear_down_state_after_each_story_run=True)
+ tear_down_after_story=True)
self.assertEquals(TestSharedStateForTearDown.num_of_tear_downs, 3)
+ self.options.pageset_repeat = 5
+ TestSharedStateForTearDown.num_of_tear_downs = 0
+ story_runner.Run(mock.MagicMock(), story_set, self.options, self.results,
+ tear_down_after_story_set=True)
+ self.assertEquals(TestSharedStateForTearDown.num_of_tear_downs, 5)
+
def testTearDownIsCalledOnceForEachStoryGroupWithPageSetRepeat(self):
self.options.pageset_repeat = 3
fooz_init_call_counter = [0]
« no previous file with comments | « telemetry/telemetry/internal/story_runner.py ('k') | telemetry/telemetry/internal/util/webpagereplay.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698