Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: telemetry/telemetry/core/exceptions.py

Issue 2162963002: [polymer] Merge of master into polymer10-migration (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration
Patch Set: Merge polymer10-migration int polymer10-merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/core/discover.py ('k') | telemetry/telemetry/internal/actions/action_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/core/exceptions.py
diff --git a/telemetry/telemetry/core/exceptions.py b/telemetry/telemetry/core/exceptions.py
index 107562521f396c3d5dd42ab5f6bc9b9facaa8c2c..ee9881ebdff6abfc709af3208bd0405b4b35e281 100644
--- a/telemetry/telemetry/core/exceptions.py
+++ b/telemetry/telemetry/core/exceptions.py
@@ -59,10 +59,12 @@ class AppCrashException(Error):
self._is_valid_dump = False
self._stack_trace = []
self._app_stdout = []
+ self._minidump_path = ''
if app:
try:
self._is_valid_dump, trace_output = app.GetStackTrace()
self._stack_trace = trace_output.splitlines()
+ self._minidump_path = app.GetMostRecentMinidumpPath()
except Exception as err:
logging.error('Problem when trying to gather stack trace: %s' % err)
try:
@@ -75,6 +77,10 @@ class AppCrashException(Error):
return self._stack_trace
@property
+ def minidump_path(self):
+ return self._minidump_path
+
+ @property
def is_valid_dump(self):
return self._is_valid_dump
@@ -93,7 +99,6 @@ class AppCrashException(Error):
debug_messages.append(divider)
return '\n'.join(debug_messages)
-
class DevtoolsTargetCrashException(AppCrashException):
"""Represents a crash of the current devtools target but not the overall app.
« no previous file with comments | « telemetry/telemetry/core/discover.py ('k') | telemetry/telemetry/internal/actions/action_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698