Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: telemetry/telemetry/internal/backends/browser_backend.py

Issue 2162963002: [polymer] Merge of master into polymer10-migration (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration
Patch Set: Merge polymer10-migration int polymer10-merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/backends/browser_backend.py
diff --git a/telemetry/telemetry/internal/backends/browser_backend.py b/telemetry/telemetry/internal/backends/browser_backend.py
index ede3495b7f5fe802c31361fdfd8ba0d756ed4f84..aca5857e7364fa2510163c4474ca8492aea62a62 100644
--- a/telemetry/telemetry/internal/backends/browser_backend.py
+++ b/telemetry/telemetry/internal/backends/browser_backend.py
@@ -40,6 +40,8 @@ class BrowserBackend(app_backend.AppBackend):
raise NotImplementedError
def GetLogFileContents(self):
+ if not self.log_file_path:
+ return 'No log file'
with file(self.log_file_path) as f:
return f.read()
@@ -118,6 +120,18 @@ class BrowserBackend(app_backend.AppBackend):
def GetStackTrace(self):
raise NotImplementedError()
+ def GetMostRecentMinidumpPath(self):
+ raise NotImplementedError()
+
+ def GetAllMinidumpPaths(self):
+ raise NotImplementedError()
+
+ def GetAllUnsymbolizedMinidumpPaths(self):
+ raise NotImplementedError()
+
+ def SymbolizeMinidump(self, minidump_path):
+ raise NotImplementedError()
+
def GetSystemInfo(self):
raise NotImplementedError()

Powered by Google App Engine
This is Rietveld 408576698