Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2166)

Unified Diff: dashboard/dashboard/issue_tracker_service_test.py

Issue 2162963002: [polymer] Merge of master into polymer10-migration (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration
Patch Set: Merge polymer10-migration int polymer10-merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dashboard/dashboard/issue_tracker_service.py ('k') | dashboard/dashboard/start_try_job.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/issue_tracker_service_test.py
diff --git a/dashboard/dashboard/issue_tracker_service_test.py b/dashboard/dashboard/issue_tracker_service_test.py
index 0861e33df88af0b25d06aaf1ea2d13b009a42c9c..f66b491bb33d0945c6ea76032a3f7cae00ba9c2c 100644
--- a/dashboard/dashboard/issue_tracker_service_test.py
+++ b/dashboard/dashboard/issue_tracker_service_test.py
@@ -21,7 +21,7 @@ class IssueTrackerServiceTest(testing_common.TestCase):
self.assertTrue(service.AddBugComment(12345, 'The comment'))
self.assertEqual(1, service._MakeCommentRequest.call_count)
service._MakeCommentRequest.assert_called_with(
- 12345, {'updates': {}, 'content': 'The comment'})
+ 12345, {'updates': {}, 'content': 'The comment'}, send_email=True)
def testAddBugComment_WithNoBug_ReturnsFalse(self):
service = issue_tracker_service.IssueTrackerService()
@@ -45,7 +45,8 @@ class IssueTrackerServiceTest(testing_common.TestCase):
'labels': ['Foo'],
},
'content': 'Some other comment'
- })
+ },
+ send_email=True)
def testAddBugComment_MergeBug(self):
service = issue_tracker_service.IssueTrackerService()
@@ -60,7 +61,8 @@ class IssueTrackerServiceTest(testing_common.TestCase):
'mergedInto': 54321,
},
'content': 'Dupe'
- })
+ },
+ send_email=True)
@mock.patch('logging.error')
def testAddBugComment_Error(self, mock_logging_error):
« no previous file with comments | « dashboard/dashboard/issue_tracker_service.py ('k') | dashboard/dashboard/start_try_job.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698