Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: tracing/tracing/model/async_slice_group.html

Issue 2162963002: [polymer] Merge of master into polymer10-migration (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration
Patch Set: Merge polymer10-migration int polymer10-merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/model/async_slice.html ('k') | tracing/tracing/model/counter.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/model/async_slice_group.html
diff --git a/tracing/tracing/model/async_slice_group.html b/tracing/tracing/model/async_slice_group.html
index 2a0405d021c715641616295640beadd29c50a073..926864103c0576c224c1719f5c3d7885b289ddee 100644
--- a/tracing/tracing/model/async_slice_group.html
+++ b/tracing/tracing/model/async_slice_group.html
@@ -134,27 +134,24 @@ tr.exportTo('tr.model', function() {
return this.viewSubGroups_;
},
- findTopmostSlicesInThisContainer: function(eventPredicate, callback,
- opt_this) {
- for (var i = 0; i < this.slices.length; i++) {
- var slice = this.slices[i];
- if (slice.isTopLevel)
- slice.findTopmostSlicesRelativeToThisSlice(eventPredicate, callback,
- opt_this);
+ findTopmostSlicesInThisContainer: function*(eventPredicate, opt_this) {
+ for (var slice of this.slices) {
+ if (slice.isTopLevel) {
+ yield * slice.findTopmostSlicesRelativeToThisSlice(
+ eventPredicate, opt_this);
+ }
}
},
- childEvents: function*(eventTypePredicate, opt_this) {
+ childEvents: function*() {
// Async slices normally don't have sub-slices, and when they do,
// the sub-slice is specific to the type of async slice. Thus,
// it is not expected for sub-slices to themselves have sub-sub-slices,
// which is why we don't recurse into the sub-slices here.
- if (eventTypePredicate.call(opt_this, tr.model.AsyncSlice)) {
- for (var slice of this.slices) {
- yield slice;
- if (slice.subSlices)
- yield * slice.subSlices;
- }
+ for (var slice of this.slices) {
+ yield slice;
+ if (slice.subSlices)
+ yield * slice.subSlices;
}
},
« no previous file with comments | « tracing/tracing/model/async_slice.html ('k') | tracing/tracing/model/counter.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698