tracing/tracing/ui/side_panel/metrics_side_panel.html - Issue 2162963002: [polymer] Merge of master into polymer10-migration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/side_panel/metrics_side_panel.html

Issue 2162963002: [polymer] Merge of master into polymer10-migration (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration

Patch Set: Merge polymer10-migration int polymer10-merge Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/extras/side_panel/input_latency_side_panel.html ('k') | tracing/tracing/ui/side_panel/side_panel_container.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/side_panel/metrics_side_panel.html

diff --git a/tracing/tracing/ui/side_panel/metrics_side_panel.html b/tracing/tracing/ui/side_panel/metrics_side_panel.html

index 52f0ebbd97e6f6c0b02a42c72acd939948a08234..033b42124cf245c3c2c263771f16d228d41d90a2 100644

--- a/tracing/tracing/ui/side_panel/metrics_side_panel.html

+++ b/tracing/tracing/ui/side_panel/metrics_side_panel.html

@@ -11,8 +11,7 @@ found in the LICENSE file.

-<link rel="import" href="/tracing/value/ui/value_set_table.html">

-<link rel="import" href="/tracing/value/ui/value_set_view.html">

+<link rel="import" href="/tracing/value/ui/all_value_set_views.html">

<dom-module id="tr-ui-sp-metrics-side-panel">

@@ -187,7 +186,10 @@ tr.exportTo('tr.ui', function() {

try {

this.currentMetricTypeInfo_.constructor(values, this.model_, options);

} catch (err) {

- console.error(err.stack);

+ var metricName = this.currentMetricTypeInfo_.constructor.name;

+ console.warn(

+ metricName + ' could not be computed for the current model:\n' +

+ err.stack);

this.$.results.values = new tr.v.ValueSet([

new tr.v.FailureValue('error', {

description: err.message,