telemetry/telemetry/value/trace.py - Issue 2162963002: [polymer] Merge of master into polymer10-migration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/value/trace.py

Issue 2162963002: [polymer] Merge of master into polymer10-migration (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration

Patch Set: Merge polymer10-migration int polymer10-merge Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: telemetry/telemetry/value/trace.py

diff --git a/telemetry/telemetry/value/trace.py b/telemetry/telemetry/value/trace.py

index e3566d51d6fbc69a8a7379abd78641d31971da84..df2113bf17d4d2414deef5495d8104b923b8e0eb 100644

--- a/telemetry/telemetry/value/trace.py

+++ b/telemetry/telemetry/value/trace.py

@@ -73,7 +73,7 @@ class TraceValue(value_module.Value):

title = self.page.display_name

cmd = (['python', _TRACE2HTML_PATH] + trace_files +

['--output', tf.name] + ['--title', title])

- subprocess.check_call(cmd)

+ subprocess.check_output(cmd)

else:

logging.warning('No traces to convert to html.')

return file_handle.FromTempFile(tf)

« no previous file with comments | « telemetry/telemetry/value/scalar_unittest.py ('k') | telemetry/telemetry/web_perf/smooth_gesture_util_unittest.py » ('j') | no next file with comments »