Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: trace_processor/experimental/mappers/scheduling/map_input_blockers.html

Issue 2162963002: [polymer] Merge of master into polymer10-migration (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration
Patch Set: Merge polymer10-migration int polymer10-merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trace_processor/experimental/mappers/scheduling/map_input_blockers.html
diff --git a/perf_insights/perf_insights/mappers/scheduling/map_input_blockers.html b/trace_processor/experimental/mappers/scheduling/map_input_blockers.html
similarity index 81%
rename from perf_insights/perf_insights/mappers/scheduling/map_input_blockers.html
rename to trace_processor/experimental/mappers/scheduling/map_input_blockers.html
index 01b988e00ff4c48d4d55c6c9dedc876e43ac298a..34b16a3b4b3ebb87569899c3a71bb2c5c20bba77 100644
--- a/perf_insights/perf_insights/mappers/scheduling/map_input_blockers.html
+++ b/trace_processor/experimental/mappers/scheduling/map_input_blockers.html
@@ -35,11 +35,11 @@ tr.exportTo('pie', function() {
var mainThread = rendererHelper.mainThread;
// Look for events that represent main thread input handling that also
// have one associated flow event showing where the input came from.
- mainThread.iterateAllEvents(function(event) {
+ for (var event of mainThread.getDescendantEvents()) {
if (event.title !== 'LatencyInfo.Flow' ||
event.args['step'] !== 'HandleInputEventMain' ||
event.inFlowEvents.length !== 1) {
- return;
+ continue;
}
// Now we can derive the queueing interval from the flow event.
@@ -49,19 +49,19 @@ tr.exportTo('pie', function() {
// Find all events that intersect the queueing interval and compute how
// much they contributed to it.
- mainThread.iterateAllEvents(function(event) {
+ for (var intersectingEvent of mainThread.getDescendantEvents()) {
var eventRange =
- tr.b.Range.fromExplicitRange(event.start,
- event.start + event.duration);
+ tr.b.Range.fromExplicitRange(intersectingEvent.start,
+ intersectingEvent.start + intersectingEvent.duration);
var intersection = queueRange.findIntersection(eventRange);
if (intersection.isEmpty || intersection.duration === 0)
- return;
- if (inputBlockers[event.title] === undefined)
- inputBlockers[event.title] = [];
- inputBlockers[event.title].push(intersection.duration);
+ continue;
+ if (inputBlockers[intersectingEvent.title] === undefined)
+ inputBlockers[intersectingEvent.title] = [];
+ inputBlockers[intersectingEvent.title].push(intersection.duration);
foundInputBlockers = true;
- });
- });
+ }
+ }
}
if (!foundInputBlockers) {

Powered by Google App Engine
This is Rietveld 408576698