[polymer] Merge of master into polymer10-migration

tracing/tracing/ui/base/tab_view.html

Index: tracing/tracing/ui/base/tab_view.html
diff --git a/tracing/tracing/ui/base/tab_view.html b/tracing/tracing/ui/base/tab_view.html
index 463def18fd3384a118378290e0ab6fc64b45e394..dbd2f9ef3a6fc7e2a76214f3532e96a3b25c9a9d 100644
--- a/tracing/tracing/ui/base/tab_view.html
+++ b/tracing/tracing/ui/base/tab_view.html
@@ -5,6 +5,8 @@ Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 -->
 
+<link rel="import" href="/tracing/ui/analysis/analysis_sub_view.html">
+
 <!--
 @fileoverview A series of tabs for the analysis view that controls which
 analysis sub-view is being displayed.
@@ -55,7 +57,7 @@ and limit users to having one option selected at a time.
         border-bottom: 1px solid white;
       }
     </style>
-    <div id='tabs'>
+    <div id='tabs' hidden="[[tabsHidden]]">

[charliea (OOO until 10-5), 2016/07/19 15:08:08]

The value set view that Ben created for results2.html was the second user of
tab_view.html, which I completely rewrote on the migration branch. His use of it
included an otherwise unused feature that I deleted that allowed the user to
hide the tabs. I had to add this back in to support his use case.

       <label id=selection_description>[[label_]]</label>
       <template is=dom-repeat items=[[subViews_]]>
         <tab>
@@ -82,11 +84,15 @@ Polymer({
       type: String,
       value: () => ''
     },
+    selectedSubView_: Object,
     subViews_: {
       type: Array,
       value: () => []
     },
-    selectedSubView_: Object
+    tabsHidden: {
+      type: Boolean,
+      value: false
+    }
   },
 
   set label(newLabel) {
@@ -122,14 +128,6 @@ Polymer({
   },
 
   addSubView: function(subView) {
-    if (!(subView instanceof HTMLElement) ||

[charliea (OOO until 10-5), 2016/07/19 15:08:06]

When I rewrote the tab view, I assumed that it would only ever be used in the
analysis pane. Because the value set view started using it, I had to stop
enforcing this constraint.

-        !subView.behaviors ||
-        subView.behaviors.indexOf(
-            tr.ui.analysis.behaviors.AnalysisSubView) < 0) {
-      throw new Error('Sub-view being added must be a registered Polymer ' +
-          'element with the sub-view behavior');
-    }
-
     if (!this.selectedSubView_)
       this.selectedSubView = subView;