Issue 2162953005: DBC: A bit of Polymorphic instance call

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2162953005: DBC: A bit of Polymorphic instance call (Closed)

Created:
4 years, 5 months ago by zra

Modified:
4 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

DBC: A bit of Polymorphic instance call Only for the case without checks. Still enough for a good bump on Richards. I've also increased the number of "registers" to 32 to get rid of the SPILLs on DeltaBlue, but couldn't see a performnace improvement. Probably better not to bail out, though. R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/8aed249e887eaa6dcceab7651fdb3b5c66b7d71a

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	M	runtime/vm/constants_dbc.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	runtime/vm/intermediate_language_dbc.cc	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

zra

4 years, 5 months ago (2016-07-20 15:54:55 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8aed249e887eaa6dcceab7651fdb3b5c66b7d71a (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages