ipc/ipc_channel_win.cc - Issue 216293008: Add a temporary CHECK to IPC::Channel::Send() to help track down crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_channel_win.cc

Issue 216293008: Add a temporary CHECK to IPC::Channel::Send() to help track down crash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/ipc_channel_win.cc

diff --git a/ipc/ipc_channel_win.cc b/ipc/ipc_channel_win.cc

index d044ef179f470528bd73e2463241108ad923c369..3f2c79a5e83a899eec30177c9115c4cd039db26c 100644

--- a/ipc/ipc_channel_win.cc

+++ b/ipc/ipc_channel_win.cc

@@ -81,6 +81,7 @@ void Channel::ChannelImpl::Close() {

}

bool Channel::ChannelImpl::Send(Message* message) {

+ CHECK(message) << "crbug.com/357915"; // TODO(vtl): Remove once bug resolved.

no sievers 2014/03/29 20:48:40 I think we need more sanity checking on the messag

DCHECK(thread_check_->CalledOnValidThread());

DVLOG(2) << "sending message @" << message << " on channel @" << this

<< " with type " << message->type()

« no previous file with comments | « ipc/ipc_channel_posix.cc ('k') | no next file » | no next file with comments »